[Heimdal-source-changes] [heimdal/heimdal] c4a060: Fix never valid error condition in KDC

[GitHub]

  Branch: refs/heads/heimdal-1-6-branch
  Home:   https://github.com/heimdal/heimdal
  Commit: c4a060c3c7bef4fb8d5e42235ff0c12ed5c51906
      https://github.com/heimdal/heimdal/commit/c4a060c3c7bef4fb8d5e42235ff0c12ed5c51906
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-11-26 (Tue, 26 Nov 2013)

  Changed paths:
    M kdc/krb5tgs.c

  Log Message:
  -----------
  Fix never valid error condition in KDC

The TGS was incorrectly using authtime to compute renew_till for new
tickets, which was in turn leading to endtime potentially being equal to
starttime, which caused the TGS to return KRB5KDC_ERR_NEVER_VALID.

This happens when the TGT renewal lifetime is longer than the max renew
lifetime of any other services, after that much time (target services'
max renew life) passes.  The TGT is still good but TGS-REQs fail.