[Heimdal-source-changes] [heimdal/heimdal] ccb148: lib/hdb/db3.c:DB_open() needs to DB_close() more

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: ccb148eedbbc5a6d91754b126ae766ded7ac9805
      https://github.com/heimdal/heimdal/commit/ccb148eedbbc5a6d91754b126ae766ded7ac9805
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M lib/hdb/db3.c

  Log Message:
  -----------
  lib/hdb/db3.c:DB_open() needs to DB_close() more

Without this the KDC can trip the assert in DB_open().


  Commit: 0f1ae2d10186afb654df8f50cc78663eb53f27a9
      https://github.com/heimdal/heimdal/commit/0f1ae2d10186afb654df8f50cc78663eb53f27a9
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M lib/krb5/get_cred.c

  Log Message:
  -----------
  Use KRB5_TC_MATCH_TIMES when looking for creds


  Commit: 0866ee2615f779cd3262c65237ac13b1f38bde7c
      https://github.com/heimdal/heimdal/commit/0866ee2615f779cd3262c65237ac13b1f38bde7c
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M lib/krb5/fcache.c

  Log Message:
  -----------
  Make fcc_remove_cred() better

Don't use a memory ccache go between, just copy all but the matching
credential(s).


  Commit: e3eb1305f58f542d63eb08ee8b08ba055d6e88bb
      https://github.com/heimdal/heimdal/commit/e3eb1305f58f542d63eb08ee8b08ba055d6e88bb
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M lib/krb5/fcache.c

  Log Message:
  -----------
  Make Refuses to open symlinks msg less spurious

If we're racing enough we could complain about symlinks where there were
none.  This was very surprising.  Make it surprise less.

We should really #ifndef O_NOFOLLOW that code chunk too, for the obvious
reason that we don't need to worry about symlinks if we have and use
O_NOFOLLOW.

Also, since all uses of fcc_open() use O_NOFOLLOW we should move that
into fcc_open().  Ditto O_BINARY and O_CLOEXEC.


  Commit: a9bd3c6e5043fb3bb67dc338cf5a7e745a90590e
      https://github.com/heimdal/heimdal/commit/a9bd3c6e5043fb3bb67dc338cf5a7e745a90590e
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M lib/krb5/fcache.c

  Log Message:
  -----------
  Fix racy file ccache corruption in cred_delete()

We *really* need a ccache instance ID tag.  In fact, we should probably
never krb5_cc_initialize() a ccache that doesn't have such a tag.  But
for now cred_delete() is now safe enough.


  Commit: 8feed14fd08dbefbf3c41c1b4c75703fefef9521
      https://github.com/heimdal/heimdal/commit/8feed14fd08dbefbf3c41c1b4c75703fefef9521
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M lib/krb5/fcache.c

  Log Message:
  -----------
  Only gate the st_uid fcache checks


  Commit: be816fadd433c33e6367d3c46aa557967d8e938b
      https://github.com/heimdal/heimdal/commit/be816fadd433c33e6367d3c46aa557967d8e938b
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M lib/krb5/fcache.c

  Log Message:
  -----------
  Minor refactoring in fcache of common open flags


  Commit: ff0bdc9bc85017377e85ecf25637f0d17ef10a9c
      https://github.com/heimdal/heimdal/commit/ff0bdc9bc85017377e85ecf25637f0d17ef10a9c
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M lib/krb5/test_cc.c

  Log Message:
  -----------
  Test improved fcc_remove_cred()


  Commit: d03e8cd91d7f42060b814a29fb85a618a0bd261f
      https://github.com/heimdal/heimdal/commit/d03e8cd91d7f42060b814a29fb85a618a0bd261f
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M kuser/copy_cred_cache.c

  Log Message:
  -----------
  Use krb5_timeofday() in kuser/copy_cred_cache.c


  Commit: c5867bde0e74b21b4ed8a105297b08213bfd5404
      https://github.com/heimdal/heimdal/commit/c5867bde0e74b21b4ed8a105297b08213bfd5404
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M kuser/kcpytkt.c
    M kuser/kdeltkt.c

  Log Message:
  -----------
  Add options to kcpytkt and kdeltkt for exp tix


  Commit: 13c8a2c2124ba1a9af53e64304d4ca9b1e809dbc
      https://github.com/heimdal/heimdal/commit/13c8a2c2124ba1a9af53e64304d4ca9b1e809dbc
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M kuser/kinit.c

  Log Message:
  -----------
  Make kinit cmd not exit on transient errors


  Commit: 8ce9a1d686bc078dcf7d26559c9145ee86f181e3
      https://github.com/heimdal/heimdal/commit/8ce9a1d686bc078dcf7d26559c9145ee86f181e3
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M kuser/kinit.c

  Log Message:
  -----------
  Allow batch mode in kinit with password file


  Commit: 79ca0dfe75d9ac5829ae5315b912a17e1f65f79e
      https://github.com/heimdal/heimdal/commit/79ca0dfe75d9ac5829ae5315b912a17e1f65f79e
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M kuser/kinit.c

  Log Message:
  -----------
  kinit should save cc configs if it krb5_cc_move()s

Also, renew_validate() should krb5_cc_new_unique() and krb5_cc_move() it
into place.


  Commit: 6d5741d03b44dbd811ec9e8a8b7f4dac250547f5
      https://github.com/heimdal/heimdal/commit/6d5741d03b44dbd811ec9e8a8b7f4dac250547f5
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M kuser/kinit.c

  Log Message:
  -----------
  kinit cmd: back-off more slowly and warn

Also refactor AFS klog code so we do it only once on renew.


  Commit: 8696739102cfb174f0e5f7640980556efbc259ec
      https://github.com/heimdal/heimdal/commit/8696739102cfb174f0e5f7640980556efbc259ec
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M kuser/kinit.c

  Log Message:
  -----------
  Add SIGINFO support for kinit cmd

Use SIGUSR1 if there's no SIGINFO, so the code isn't dead.


  Commit: c9d390acac89be1a2eb46a202cb3489bb72756a0
      https://github.com/heimdal/heimdal/commit/c9d390acac89be1a2eb46a202cb3489bb72756a0
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M kuser/kinit.c

  Log Message:
  -----------
  Don't use "if (!ret)"


  Commit: 36f22356c5ef0e15569172a33cdc1b71c5c40787
      https://github.com/heimdal/heimdal/commit/36f22356c5ef0e15569172a33cdc1b71c5c40787
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M tests/kdc/Makefile.am
    A tests/kdc/check-kinit.in

  Log Message:
  -----------
  Add [manual] test of kinit cmd

It's not ready to always be run.  First, it's slow.  Second, it tortures
the system.  Third, it doesn't look for signs of failure.  Fourth, if it
did it'd fail: because something about the racing is causing the KDC to
think that the foo principal doesn't exist.


  Commit: 129b4f37207f11b3d34cd573ac2a3087b1670311
      https://github.com/heimdal/heimdal/commit/129b4f37207f11b3d34cd573ac2a3087b1670311
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M kuser/kinit.c

  Log Message:
  -----------
  Fix warning in ! NO_AFS case


Compare: https://github.com/heimdal/heimdal/compare/6ae305e7a43c...129b4f37207f