[Heimdal-source-changes] [heimdal/heimdal] 79b7b0: hcrypto: w32crypto crypt provider handle leak

[GitHub]

  Branch: refs/heads/heimdal-1-6-branch
  Home:   https://github.com/heimdal/heimdal
  Commit: 79b7b074a009dc50e3de16c84fb27efadad40429
      https://github.com/heimdal/heimdal/commit/79b7b074a009dc50e3de16c84fb27efadad40429
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2014-12-24 (Wed, 24 Dec 2014)

  Changed paths:
    M lib/hcrypto/rand-w32.c

  Log Message:
  -----------
  hcrypto: w32crypto crypt provider handle leak

_hc_CryptProvider() returns a global handle to a Win32 Crypt Provider.
If the global handle is NULL, then a handle is allocated.  Unfortunately,
due to a coding mistake the global handle variable, g_cryptprovider, was
never set and a new handle was allocated with each call.

Refactor the function to ensure that the global handle is the value
that is returned.  Use NULL instead of 0 for pointer assignment.

Change-Id: If1ef3aa19cbd1d51860370db24c086e86922ff0d
(cherry picked from commit b3f29170a35a8e249cd512db682e7f4092af663e)