[Heimdal-source-changes] [heimdal/heimdal] f132e0: GSSAPI: update lib/gssapi/gen-oid.pl to work with ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: f132e0b2a3c66becd305f6f2ac1c311f6e453001
      https://github.com/heimdal/heimdal/commit/f132e0b2a3c66becd305f6f2ac1c311f6e453001
  Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
  Date:   2015-07-31 (Fri, 31 Jul 2015)

  Changed paths:
    M lib/gssapi/gen-oid.pl

  Log Message:
  -----------
  GSSAPI: update lib/gssapi/gen-oid.pl to work with Perl 5

The invocation `require "getopts.pl"; Getopts(...)` works in Perl 4,
but not in recent Perl 5.

Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>


  Commit: afab2ff86778340fc54f532c2dcf2d383f393a48
      https://github.com/heimdal/heimdal/commit/afab2ff86778340fc54f532c2dcf2d383f393a48
  Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
  Date:   2015-07-31 (Fri, 31 Jul 2015)

  Changed paths:
    M lib/gssapi/mech/gss_oid.c

  Log Message:
  -----------
  GSSAPI: use rk_UNCONST() on password and cert oid

These missed out on the rk_UNCONST()ification by virtue of being added
in a parallel branch. In the diagram below, they got added in 02cf28e,
while the rk_UNCONSTs were added in f5f9014.

* cc47c8f Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
*   3069d80 Merge branch 'master' into lukeh/acquire-cred-ex
|\
| * f5f9014 Warning fixes from Christos Zoulas
* | 02cf28e implement gss_acquire_cred_ex with password support
|/
* 2170219 add more oids

rk_UNCONST amounts to a cast to (void *), removing const.

Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>


  Commit: 0c36f11f1793ae84f1d06ea36f0e8d746d26e3fe
      https://github.com/heimdal/heimdal/commit/0c36f11f1793ae84f1d06ea36f0e8d746d26e3fe
  Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
  Date:   2015-07-31 (Fri, 31 Jul 2015)

  Changed paths:
    M lib/gssapi/gen-oid.pl

  Log Message:
  -----------
  GSSAPI: keep consistent sort order in lib/gssapi/gen-oid.pl

Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>


  Commit: 0d31145e9defc7d58953a13c422ccac407ce6b61
      https://github.com/heimdal/heimdal/commit/0d31145e9defc7d58953a13c422ccac407ce6b61
  Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
  Date:   2015-07-31 (Fri, 31 Jul 2015)

  Changed paths:
    M lib/gssapi/gen-oid.pl

  Log Message:
  -----------
  GSSAPI: generate full NULL structure initializers in gen-oid.pl

As seen in commit cc47c8fa7 (Roland C. Dowdeswell <elric at imrryr.org>,
"Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix
issues"), compilers can be persuaded to dislike a single {NULL} and
prefer {NULL, NULL, NULL, NULL}. That patch altered the C code
directly; here we change the generating file to match.

Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>


  Commit: 832d7af01872252c9e9c754a6387971622d3e30c
      https://github.com/heimdal/heimdal/commit/832d7af01872252c9e9c754a6387971622d3e30c
  Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
  Date:   2015-07-31 (Fri, 31 Jul 2015)

  Changed paths:
    M lib/gssapi/mech/gss_oid.c

  Log Message:
  -----------
  GSSAPI: regenerate lib/gssapi/mech/gss_oid.c with consistent sort

This is generated from lib/gssapi/oid.txt using lib/gssapi/gen-oid.pl,
which sorts the entries to ensure minimal diff churn when an oid is
added or changed.

The lack of effective changes can be seen by sorting both versions, a
bit like this:

$ git show HEAD~~:lib/gssapi/mech/gss_oid.c | sort > /tmp/gss_oid.c-OLD
$ cat lib/gssapi/mech/gss_oid.c | sort > /tmp/gss_oid.c-NEW
$ diff -u /tmp/gss_oid.c*
$ #Nothing to see!

This is of course not a reliable check in general, but works for this
simple file in concert with ordinary inspection.

Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>


  Commit: 71c95fb38d1edba18ff3fe059215115b9d8bb56f
      https://github.com/heimdal/heimdal/commit/71c95fb38d1edba18ff3fe059215115b9d8bb56f
  Author: Andrew Bartlett <abartlet at samba.org>
  Date:   2015-07-31 (Fri, 31 Jul 2015)

  Changed paths:
    M lib/gssapi/gen-oid.pl
    M lib/gssapi/mech/gss_oid.c

  Log Message:
  -----------
  Merge pull request #137 from douglasbagnall/oid-regenerate

Oid regenerate

The GSSAPI oid C files were originally generated by a perl 4 script that no longer runs on a modern system. Subsequently the C has been manually modified.

These patches update the script to perl 5 and alter its output to reflect the manually changed C.

Because modern perl uses hash randomisation, the order of the oids in the C file is sorted -- otherwise
they will be ordered differently every time, making changes hard to review.


Compare: https://github.com/heimdal/heimdal/compare/db4175c2258c...71c95fb38d1e