[Heimdal-source-changes] [heimdal/heimdal] a1c87d: Add guard in krb5_free_creds()

Tis Mars 24 18:25:53 CET 2015

  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: a1c87df26077aaaa8cd644c3d5400cbbd61a3379
      https://github.com/heimdal/heimdal/commit/a1c87df26077aaaa8cd644c3d5400cbbd61a3379
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M lib/krb5/creds.c

  Log Message:
  -----------
  Add guard in krb5_free_creds()

Don't call krb5_free_contents() if the creds pointer is NULL.

MIT krb5 also has this guard.

  Commit: 487b6820f6c6e5d0ce1bc515b2180fa5533a6a50
      https://github.com/heimdal/heimdal/commit/487b6820f6c6e5d0ce1bc515b2180fa5533a6a50
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M lib/asn1/krb5.asn1
    M lib/gssapi/krb5/acquire_cred.c
    M lib/gssapi/krb5/canonicalize_name.c
    M lib/gssapi/krb5/import_name.c
    M lib/gssapi/krb5/init_sec_context.c
    M lib/krb5/context.c
    M lib/krb5/get_cred.c
    M lib/krb5/init_creds_pw.c
    M lib/krb5/keytab.c
    M lib/krb5/krb5.h
    M lib/krb5/krb5_locl.h
    M lib/krb5/principal.c
    M tests/kdc/krb5-canon2.conf.in

  Log Message:
  -----------
  Revamp name canonicalization code

  Commit: 5fffc4061f8f8cb1dc00a7cb6267cac7498d748f
      https://github.com/heimdal/heimdal/commit/5fffc4061f8f8cb1dc00a7cb6267cac7498d748f
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M lib/krb5/principal.c

  Log Message:
  -----------
  Don't use canon rules in principal name comparison

  Commit: a7587b08e2920fd46f349bb0bbab2999fb5defd1
      https://github.com/heimdal/heimdal/commit/a7587b08e2920fd46f349bb0bbab2999fb5defd1
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M lib/krb5/principal.c

  Log Message:
  -----------
  Support hostname:port svc princs

  Commit: 0778b19c3fd9ab8be73df107cf2196bbc69b90b9
      https://github.com/heimdal/heimdal/commit/0778b19c3fd9ab8be73df107cf2196bbc69b90b9
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M lib/krb5/krb5.conf.5

  Log Message:
  -----------
  Revive name rule docs

  Commit: b48bed5f42c02fe8562c7ce623172cf3e29c9c90
      https://github.com/heimdal/heimdal/commit/b48bed5f42c02fe8562c7ce623172cf3e29c9c90
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M cf/roken-frag.m4
    M kadmin/kadm_conn.c
    M kadmin/kadmind.c
    M kcm/config.c
    M kcm/kcm_locl.h
    M kcm/main.c
    M kdc/config.c
    M kdc/connect.c
    M kdc/kdc-tester.c
    M kdc/kdc_locl.h
    M kdc/main.c
    M kpasswd/kpasswdd.c
    M lib/kadm5/ipropd_master.c
    M lib/kadm5/ipropd_slave.c
    M lib/krb5/principal.c
    M lib/roken/Makefile.am
    M lib/roken/NTMakefile
    M lib/roken/daemon.c
    A lib/roken/detach.c
    M lib/roken/getarg.c
    M lib/roken/roken-common.h
    M lib/roken/roken.h.in
    A lib/roken/test-detach.c
    M lib/roken/version-script.map
    M lib/roken/write_pid.c

  Log Message:
  -----------
  Daemons detach atomically to avoid having to wait

Tests that start daemons have to "wait" for them to start.

This commit makes Heimdal daemons prep to detach (when requested) by
forking early, then having the child signal readiness to the parent when
the child really is ready.  The parent exits only which the child is
ready.  This means that tests will no longer need to wait for daemons.

However, tests will still need a pidfile or such so they can stop the
daemons.

Note that the --detach options should not be used on OS X from launchd,
only from tests.

  Commit: e75f790fe6d600e72ada211a7afdac16d9a24084
      https://github.com/heimdal/heimdal/commit/e75f790fe6d600e72ada211a7afdac16d9a24084
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M cf/roken-frag.m4
    M lib/roken/issuid.c

  Log Message:
  -----------
  Use getauxval() for issuid() on Linux

  Commit: 3021258f6064a7bdb46bb2e039a093230650b408
      https://github.com/heimdal/heimdal/commit/3021258f6064a7bdb46bb2e039a093230650b408
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M tests/bin/Makefile.am
    A tests/bin/intr.c

  Log Message:
  -----------
  Add tests/bin/intr

This utility, inspired by the old SunOS 4.x intr(8) utility, will be
used to start daemons with --detach and a timeout, like this:

    intr -t 5 kdc --detach || { echo failed to start kdc; exit 1 }

This will allow tests to stop having to sleep poll for "started" output
from the daemons they start, allowing them to run faster and to impose a
reasonable timeout on daemon startup.

The default timeout is 3 seconds.

  Commit: 533578e7266f6e3d8f941eff014b06c817534f5a
      https://github.com/heimdal/heimdal/commit/533578e7266f6e3d8f941eff014b06c817534f5a
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M lib/gssapi/krb5/store_cred.c
    M lib/gssapi/mech/gss_store_cred.c

  Log Message:
  -----------
  Make gss_store_cred() work

  Commit: df41d53c674f9296641d88532ff3b22abb4216b9
      https://github.com/heimdal/heimdal/commit/df41d53c674f9296641d88532ff3b22abb4216b9
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M lib/gssapi/krb5/add_cred.c

  Log Message:
  -----------
  Fix gss_add_cred() (krb5)

gss_add_cred() with GSS_C_NO_CREDENTIAL as the input_cred_handle should
act like gss_acquire_cred() with desired_mechs containing just the
desired_mech.

  Commit: f73c4edf696d018326e34d9e1648ce2f420a48da
      https://github.com/heimdal/heimdal/commit/f73c4edf696d018326e34d9e1648ce2f420a48da
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M lib/gssapi/Makefile.am
    M lib/gssapi/krb5/store_cred.c
    M tests/gss/check-basic.in

  Log Message:
  -----------
  Fix gss_store_cred()

  Commit: a318ac86f5fde13bb1adcdcb145ded1550b0888e
      https://github.com/heimdal/heimdal/commit/a318ac86f5fde13bb1adcdcb145ded1550b0888e
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M tests/gss/Makefile.am

  Log Message:
  -----------
  Run tests/gss/check-basic

  Commit: 89aed008a95b5b17ae56df3466842dbd15ad2d13
      https://github.com/heimdal/heimdal/commit/89aed008a95b5b17ae56df3466842dbd15ad2d13
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M kuser/kswitch.c

  Log Message:
  -----------
  Fix memleak in kswitch

  Commit: d07d93ce3546bc64ea203ab9971c48ccf667a7fa
      https://github.com/heimdal/heimdal/commit/d07d93ce3546bc64ea203ab9971c48ccf667a7fa
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M lib/krb5/aname_to_localname.c

  Log Message:
  -----------
  Bounds check in aname2lname

  Commit: 13759fb73f70b01709102e87dd55055c1d7c9082
      https://github.com/heimdal/heimdal/commit/13759fb73f70b01709102e87dd55055c1d7c9082
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M lib/kadm5/free.c

  Log Message:
  -----------
  Free kadm5 princ policy

  Commit: 2bbf56b2e4ca46813d23e875f6c947587f6cafe2
      https://github.com/heimdal/heimdal/commit/2bbf56b2e4ca46813d23e875f6c947587f6cafe2
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M lib/krb5/aname_to_localname.c

  Log Message:
  -----------
  Fix error-case memleak in aname2lname

  Commit: 2fbd7331a65d39730a6167b0a1232206110c712a
      https://github.com/heimdal/heimdal/commit/2fbd7331a65d39730a6167b0a1232206110c712a
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M lib/base/db.c

  Log Message:
  -----------
  Fix error-case leaks in lib/base/db.c

  Commit: 86017e8798e81b3be95884cf6171acf37a545972
      https://github.com/heimdal/heimdal/commit/86017e8798e81b3be95884cf6171acf37a545972
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M lib/krb5/test_kuserok.c

  Log Message:
  -----------
  Fix leaks in test_kuserok.c

  Commit: b81f16abf648e458722a9d5de0e1da551da74f45
      https://github.com/heimdal/heimdal/commit/b81f16abf648e458722a9d5de0e1da551da74f45
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M kuser/kswitch.c

  Log Message:
  -----------
  Fix memleak in kswitch rare error

  Commit: 3d54f93bed83877ff19a8c2e18fe15ff7ef69176
      https://github.com/heimdal/heimdal/commit/3d54f93bed83877ff19a8c2e18fe15ff7ef69176
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M kadmin/ank.c

  Log Message:
  -----------
  Fix leak in kadmin ank

  Commit: 333c6fe95d272dfd4441579096cbe0040d4e423b
      https://github.com/heimdal/heimdal/commit/333c6fe95d272dfd4441579096cbe0040d4e423b
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M kuser/kinit.c

  Log Message:
  -----------
  Fix leak in kinit

  Commit: 945fe5fb2f904be4cafb0d2d5ab14d76e928de6d
      https://github.com/heimdal/heimdal/commit/945fe5fb2f904be4cafb0d2d5ab14d76e928de6d
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M lib/krb5/fcache.c

  Log Message:
  -----------
  Fix leak in fcc_remove_cred()

  Commit: 465483de49cae3b5caf623a299dc0e4e8e5dd065
      https://github.com/heimdal/heimdal/commit/465483de49cae3b5caf623a299dc0e4e8e5dd065
  Author: Nicolas Williams <nico at cryptonector.com>
  Date:   2015-03-24 (Tue, 24 Mar 2015)

  Changed paths:
    M lib/krb5/test_kuserok.c

  Log Message:
  -----------
  Fix use after free in test_kuserok.c

Compare: https://github.com/heimdal/heimdal/compare/902aa4ee02da...465483de49ca