[Heimdal-source-changes] [heimdal/heimdal] 7c8b66: Use off_t in for constants used in iprop log seeks

GitHub noreply at github.com
Ons Nov 9 20:56:23 CET 2016


  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: 7c8b66d76b562912c09c0955a53da2f26afbc8f7
      https://github.com/heimdal/heimdal/commit/7c8b66d76b562912c09c0955a53da2f26afbc8f7
  Author: Sergio Gelato <Sergio.Gelato at astro.su.se>
  Date:   2016-11-09 (Wed, 09 Nov 2016)

  Changed paths:
    M lib/kadm5/log.c

  Log Message:
  -----------
  Use off_t in for constants used in iprop log seeks

On 32-bit architectures with _FILE_OFFSET_BITS=64,
 sizeof(off_t) > sizeof(size_t) .

LOG_HEADER_SZ was #define'd as an expression of type size_t, so in order
to get the sign extension right we need -(off_t)LOG_HEADER_SZ instead of
(off_t)(-LOG_HEADER_SZ).  However, we can just define the *_SZ macros to
cast to off_t, then we don't need to worry about negation.

Fixes Debian bug #822749, PR 175.

Signed-off-by (and updated by): Nicolas Williams <nico at twosigma.com>




More information about the Heimdal-source-changes mailing list