[Heimdal-source-changes] [heimdal/heimdal] 6d27e0: Make builds reproduceable (#336)

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: 6d27e0048963955b547584f004109bbbad6e9baf
      https://github.com/heimdal/heimdal/commit/6d27e0048963955b547584f004109bbbad6e9baf
  Author: Nicolas Williams <nico at twosigma.com>
  Date:   2017-09-29 (Fri, 29 Sep 2017)

  Changed paths:
    M Makefile.am
    R cf/krb-version.m4
    M configure.ac

  Log Message:
  -----------
  Make builds reproduceable (#336)


  Commit: b2f6ba0fff60aba5af96cdd0c7e26047e0adf396
      https://github.com/heimdal/heimdal/commit/b2f6ba0fff60aba5af96cdd0c7e26047e0adf396
  Author: Nicolas Williams <nico at twosigma.com>
  Date:   2017-10-05 (Thu, 05 Oct 2017)

  Changed paths:
    M lib/krb5/krbhst.c

  Log Message:
  -----------
  Revert "lib: Fix printing a short into portstr"

This reverts commit ccb63bb0aae60f4d2286dc0bd01656602a087308, which was
unnecessary and broke tests/kdc/check-kadmin (and other things).

host->port happens to be an unsigned short, so that promotion to an integer in
the snprintf() call is safe in that the promoted value will still be
non-negative, and no larger than an unsigned short's maximum value.  We're
still assuming that 7 bytes is sufficient to hold the text representation of
that maximum value, which indeed it is, assuming sizeof(unsigned short) == 2
and CHAR_BIT == 8, which are fair assumptions here.  A better patch, if we
needed it, would be to just make portstr[] an array of 11 char, or perhaps make
it a VLA (but we can't yet use VLAs, I don't think, because of older Windows
systems that must be supported still).


Compare: https://github.com/heimdal/heimdal/compare/e7879208e47f...b2f6ba0fff60