[Heimdal-source-changes] [heimdal/heimdal] 7515d7: lib/ipc: client double close of socket file descri...

[GitHub]

  Branch: refs/heads/jaltman/lib-ipc-double-close
  Home:   https://github.com/heimdal/heimdal
  Commit: 7515d7e8f43e0c57bd89f2b9d95948bebf4f042e
      https://github.com/heimdal/heimdal/commit/7515d7e8f43e0c57bd89f2b9d95948bebf4f042e
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2018-12-26 (Wed, 26 Dec 2018)

  Changed paths:
    M lib/ipc/client.c

  Log Message:
  -----------
  lib/ipc: client double close of socket file descriptor #431

When connect() fails in connect_unix() the path_ctx.fd is not
set to -1 after close().  When common_release() is executed due
to the error return from connect_unix() it calls close() a second
time.

There is no need to call close() from connect_unix(). Remove the
duplicate request.

This issue was reported by YASUOKA Masahiko.

Change-Id: I825e274cc7f12e50a8779a2b62ddb756817cdb52



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.