[Heimdal-source-changes] [heimdal/heimdal] e6d1c1: Rewrite gss_add_cred() (fix #413)

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: e6d1c10808bae4853b005bd981878c42c3432cfe
      https://github.com/heimdal/heimdal/commit/e6d1c10808bae4853b005bd981878c42c3432cfe
  Author: Nicolas Williams <nico at twosigma.com>
  Date:   2018-12-28 (Fri, 28 Dec 2018)

  Changed paths:
    M lib/gssapi/Makefile.am
    M lib/gssapi/NTMakefile
    M lib/gssapi/gssapi/gssapi.h
    M lib/gssapi/gssapi_mech.h
    A lib/gssapi/krb5/duplicate_cred.c
    M lib/gssapi/krb5/external.c
    M lib/gssapi/krb5/test_acquire_cred.c
    M lib/gssapi/krb5/test_cred.c
    M lib/gssapi/mech/gss_add_cred.c
    A lib/gssapi/mech/gss_duplicate_cred.c
    A lib/gssapi/netlogon/duplicate_cred.c
    M lib/gssapi/netlogon/external.c
    M lib/gssapi/netlogon/netlogon.h
    A lib/gssapi/ntlm/duplicate_cred.c
    M lib/gssapi/ntlm/external.c
    M lib/gssapi/ntlm/ntlm.h
    M lib/gssapi/spnego/external.c

  Log Message:
  -----------
  Rewrite gss_add_cred() (fix #413)

It turns out gss_add_cred() really needed a complete rewrite.  It's much
better to first have a gss_duplicate_cred() (which has been needed for
other reasons anyways), and use that when the input_cred_handle is not
GSS_C_NO_CREDENTIAL and output_cred_handle is not NULL, then mutate that
duplicate credential handle (or the input_cred_handle if
output_cred_handle is NULL).



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.