[Heimdal-source-changes] [heimdal/heimdal] 934d5e: hcrypto PKCS#11 backend: Call C_Initialize() on ev...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: 934d5e09bf3ba0774d303da53446e5ff94daae01
      https://github.com/heimdal/heimdal/commit/934d5e09bf3ba0774d303da53446e5ff94daae01
  Author: Luke Howard <lukeh at padl.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M lib/hcrypto/evp-pkcs11.c

  Log Message:
  -----------
  hcrypto PKCS#11 backend: Call C_Initialize() on every hcrypto call

This is required as the PKCS#11 library needs to be reinitialized after
forking. This was causing a problem with ipropd.

This fix appears to incur a repeatable 10ms performance penalty on aes-test.

Caching the initialization status using a once control and invalidating it
on fork provided no measurable performance benefit on Solaris 11. Other
approaches would not be thread-safe or would involve more intrusive code
changes, such as exposing heimbase's atomics.



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.