From noreply at github.com  Mon Sep 10 20:40:52 2018
From: noreply at github.com (GitHub)
Date: Mon, 10 Sep 2018 11:40:52 -0700
Subject: [Heimdal-source-changes] [heimdal/heimdal] 1c8cae: heimdal: Use
 #ifdef HAVE_DLOPEN around functions a...
Message-ID: <5b96bab4e40cb_2ec22acab7776ecc437ef@hookshot-fe-d252ca1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: 1c8cae58ccef6b646195940e7ca733d1c2ab7fab
      https://github.com/heimdal/heimdal/commit/1c8cae58ccef6b646195940e7ca733d1c2ab7fab
  Author: Gary Lockyer <gary at catalyst.net.nz>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M lib/gssapi/mech/gss_mech_switch.c
    M lib/krb5/plugin.c

  Log Message:
  -----------
  heimdal: Use #ifdef HAVE_DLOPEN around functions and variables used by HAVE_DLOPEN

Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>


  Commit: d99b8acd1c163f7139200bd21758e2787fa3c45c
      https://github.com/heimdal/heimdal/commit/d99b8acd1c163f7139200bd21758e2787fa3c45c
  Author: Andrew Bartlett <abartlet at samba.org>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M lib/krb5/plugin.c

  Log Message:
  -----------
  do not dereference NULL pointer modules if we do not have dlopen

Signed-off-by: Andrew Bartlett <abartlet at samba.org>


Compare: https://github.com/heimdal/heimdal/compare/492910ec1ef5...d99b8acd1c16
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From noreply at github.com  Mon Sep 10 20:42:20 2018
From: noreply at github.com (GitHub)
Date: Mon, 10 Sep 2018 11:42:20 -0700
Subject: [Heimdal-source-changes] [heimdal/heimdal] 9c2351: Correct
 "paramaters" typos.
Message-ID: <5b96bb0c8d4_34a22b21380aeedc3361@hookshot-fe-d2afb11.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: 9c2351eb25e8be4fec2de14562d4dfbc1e7823f2
      https://github.com/heimdal/heimdal/commit/9c2351eb25e8be4fec2de14562d4dfbc1e7823f2
  Author: Chris Lamb <chris at chris-lamb.co.uk>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M lib/hx509/cms.c

  Log Message:
  -----------
  Correct "paramaters" typos.

Signed-off-by: Chris Lamb <chris at chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>

(cherry-picked from Samba commit e0366ea49d5daa8fbf8b2ca22b1d3c77cc2daf9a)


  Commit: 2f3f88e53a83a1033ec57b51b85aad3a88fa5b10
      https://github.com/heimdal/heimdal/commit/2f3f88e53a83a1033ec57b51b85aad3a88fa5b10
  Author: Chris Lamb <chris at chris-lamb.co.uk>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M lib/krb5/pac.c

  Log Message:
  -----------
  Correct "allignment" typos.

Signed-off-by: Chris Lamb <chris at chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>

(cherry-picked from Samba commit 8fcc49ecd44e69d7f9ada212c63896e0dcf488a4)


  Commit: 18619449e9d4b143ac7ac52be5bc81c2de853981
      https://github.com/heimdal/heimdal/commit/18619449e9d4b143ac7ac52be5bc81c2de853981
  Author: Chris Lamb <chris at chris-lamb.co.uk>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M lib/krb5/krb5_err.et

  Log Message:
  -----------
  Correct "unavaible" typos.

Signed-off-by: Chris Lamb <chris at chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>

(cherry-picked from Samba commit 5c20790272456e547afb0ad72fb9284e2f14de30)


  Commit: 276476c595172d09d4091275430362a4e9535989
      https://github.com/heimdal/heimdal/commit/276476c595172d09d4091275430362a4e9535989
  Author: Chris Lamb <chris at chris-lamb.co.uk>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M lib/krb5/init_creds_pw.c

  Log Message:
  -----------
  Correct "updateing" typos.

Signed-off-by: Chris Lamb <chris at chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>

(cherry-picked from Samba commit fccdf34a0f7ebe510769743a99b9ef2da2a20045)


  Commit: aa119d1792f5e33d2938cfcf578d56782814d3dd
      https://github.com/heimdal/heimdal/commit/aa119d1792f5e33d2938cfcf578d56782814d3dd
  Author: Chris Lamb <chris at chris-lamb.co.uk>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M lib/hx509/keyset.c

  Log Message:
  -----------
  Correct "doesnt" typos.

Signed-off-by: Chris Lamb <chris at chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
(cherry picked from Samba commit c4feed0b8cb6df71e14a30c07e4b5560368f54cc)


  Commit: 946caad7d01295c198fe2b1a279cccccfba3cb11
      https://github.com/heimdal/heimdal/commit/946caad7d01295c198fe2b1a279cccccfba3cb11
  Author: Chris Lamb <chris at chris-lamb.co.uk>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M lib/asn1/rfc2459.asn1
    M lib/gssapi/gssapi/gssapi_oid.h

  Log Message:
  -----------
  Correct "extention" typos.

Signed-off-by: Chris Lamb <chris at chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
(cherry picked from Samba commit afa9bb4ac55d616fe7816e3830bab5e3a51aed7a)


  Commit: 6d4da04566861b97e1a52eb4dadcb8fd83b95284
      https://github.com/heimdal/heimdal/commit/6d4da04566861b97e1a52eb4dadcb8fd83b95284
  Author: Chris Lamb <chris at chris-lamb.co.uk>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M lib/hx509/cert.c
    M lib/krb5/creds.c

  Log Message:
  -----------
  Correct "existence" typos.

Signed-off-by: Chris Lamb <chris at chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
(cherry picked from Samba commit 5482e5426e09667d26e04dd0c6e0107e46e1028f)


  Commit: 7f834b63cc9a63ee8aa397a7b936c17c67fc3f58
      https://github.com/heimdal/heimdal/commit/7f834b63cc9a63ee8aa397a7b936c17c67fc3f58
  Author: Chris Lamb <chris at chris-lamb.co.uk>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M lib/hx509/cert.c

  Log Message:
  -----------
  Correct "explicity" typos.

Signed-off-by: Chris Lamb <chris at chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
(cherry picked from Samba commit 45b14b18fe3f01ae8ea22afcd112205b8a4cf9bc)


Compare: https://github.com/heimdal/heimdal/compare/d99b8acd1c16...7f834b63cc9a
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From noreply at github.com  Tue Sep 11 03:18:40 2018
From: noreply at github.com (GitHub)
Date: Mon, 10 Sep 2018 18:18:40 -0700
Subject: [Heimdal-source-changes] [heimdal/heimdal] 27c6c1: s4-heimdal: Fix
 the format-truncation errors.
Message-ID: <5b9717f0c600f_3b372ad3b6ab4ec4814e5@hookshot-fe-d2afb11.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: 27c6c1e177f0abb6a45071251f87bd7e6e3400df
      https://github.com/heimdal/heimdal/commit/27c6c1e177f0abb6a45071251f87bd7e6e3400df
  Author: Günther Deschner <gd at samba.org>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M lib/com_err/compile_et.c

  Log Message:
  -----------
  s4-heimdal: Fix the format-truncation errors.

../lib/com_err/compile_et.c: In function ‘generate_h’:
../lib/com_err/compile_et.c:138:33: error: ‘%s’ directive output may be truncated writing up to 127 bytes into a region of size 126 [-Werror=format-truncation=]
     snprintf(fn, sizeof(fn), "__%s__", hfn);
                           ^~     ~~~
../lib/com_err/compile_et.c:138:5: note: ‘snprintf’ output between 5 and 132 bytes into a destination of size 128
     snprintf(fn, sizeof(fn), "__%s__", hfn);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/com_err/compile_et.c: In function ‘main’:
../lib/com_err/compile_et.c:234:35: error: ‘.h’ directive output may be truncated writing 2 bytes into a region of size between 1 and 128 [-Werror=format-truncation=]
     snprintf(hfn, sizeof(hfn), "%s.h", Basename);
                             ^~
../lib/com_err/compile_et.c:234:5: note: ‘snprintf’ output between 3 and 130 bytes into a destination of size 128
     snprintf(hfn, sizeof(hfn), "%s.h", Basename);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/com_err/compile_et.c:235:35: error: ‘.c’ directive output may be truncated writing 2 bytes into a region of size between 1 and 128 [-Werror=format-truncation=]
     snprintf(cfn, sizeof(cfn), "%s.c", Basename);
                             ^~
../lib/com_err/compile_et.c:235:5: note: ‘snprintf’ output between 3 and 130 bytes into a destination of size 128
     snprintf(cfn, sizeof(cfn), "%s.c", Basename);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437

Guenther

Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>

Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Fri Jun  8 13:23:51 CEST 2018 on sn-devel-144
(cherry picked from Samba commit 7ddbf6035dfec6806536f99d0257245f70661363)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From noreply at github.com  Tue Sep 18 00:12:27 2018
From: noreply at github.com (GitHub)
Date: Mon, 17 Sep 2018 15:12:27 -0700
Subject: [Heimdal-source-changes] [heimdal/heimdal] 7b4ea9: Fix context
 etype leaks
Message-ID: <5ba026cb39d5b_30232afcf42b6ecc441c4@hookshot-fe-cace476.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: 7b4ea9c42fbb0cdefff6ca2848d7e3e9398aff8e
      https://github.com/heimdal/heimdal/commit/7b4ea9c42fbb0cdefff6ca2848d7e3e9398aff8e
  Author: Markus Moeller <markus_moeller at compuserve.com>
  Date:   2018-09-17 (Mon, 17 Sep 2018)

  Changed paths:
    M lib/krb5/context.c

  Log Message:
  -----------
  Fix context etype leaks


  Commit: 635ac1aa85494bca29cd6eeb3554746625c06c7d
      https://github.com/heimdal/heimdal/commit/635ac1aa85494bca29cd6eeb3554746625c06c7d
  Author: Markus Moeller <markus_moeller at compuserve.com>
  Date:   2018-09-17 (Mon, 17 Sep 2018)

  Changed paths:
    M lib/gssapi/ntlm/accept_sec_context.c

  Log Message:
  -----------
  Free context in case of error


  Commit: d570541e3d399eaa39cf8b88a6252ac9cf8333de
      https://github.com/heimdal/heimdal/commit/d570541e3d399eaa39cf8b88a6252ac9cf8333de
  Author: Jeffrey Altman <jaltman at auristor.com>
  Date:   2018-09-17 (Mon, 17 Sep 2018)

  Changed paths:
    M lib/gssapi/ntlm/accept_sec_context.c

  Log Message:
  -----------
  Update accept_sec_context.c


Compare: https://github.com/heimdal/heimdal/compare/27c6c1e177f0...d570541e3d39
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From noreply at github.com  Tue Sep 18 23:46:08 2018
From: noreply at github.com (GitHub)
Date: Tue, 18 Sep 2018 14:46:08 -0700
Subject: [Heimdal-source-changes] [heimdal/heimdal] 0f8032: Allow
 zero-length encrypt IOVs in _krb5_evp_encryp...
Message-ID: <5ba17220bc3a0_40622aaf7b8eeec830142@hookshot-fe-7191cb1.cp1-iad.github.net.mail>

  Branch: refs/heads/sxw/iovec-more-fixes
  Home:   https://github.com/heimdal/heimdal
  Commit: 0f803235a0aff0132988bc4e1bd84212a7b91032
      https://github.com/heimdal/heimdal/commit/0f803235a0aff0132988bc4e1bd84212a7b91032
  Author: Simon Wilkinson <sxw at auristor.com>
  Date:   2018-09-18 (Tue, 18 Sep 2018)

  Changed paths:
    M lib/gssapi/test_context.c
    M lib/krb5/crypto-evp.c

  Log Message:
  -----------
  Allow zero-length encrypt IOVs in _krb5_evp_encrypt_iov_cts()

The iovec encryption code doesn't handle 0 length iovecs correctly.
Instead of just skipping them, _krb5_evp_encrypt_iov_cts() will spin
on the 0 length iovec.

Modify the _krb5_evp_iov_cursor_expand helper so that iovec expansion
simply skips 0 length iovecs, and make _krb5_evp_iov_cursor_nextcrypt
do the same.

Original bug report and tests from Andrew Bartlett <abartlet at samba.org>



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From noreply at github.com  Wed Sep 19 01:23:33 2018
From: noreply at github.com (GitHub)
Date: Tue, 18 Sep 2018 16:23:33 -0700
Subject: [Heimdal-source-changes] [heimdal/heimdal] 07b3e6: Allow
 zero-length encrypt IOVs in _krb5_evp_encryp...
Message-ID: <5ba188f588b5_8d12ac840974ec8831db@hookshot-fe-7191cb1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: 07b3e6fd748e05a40d6e53b0c92d0b74f97406b2
      https://github.com/heimdal/heimdal/commit/07b3e6fd748e05a40d6e53b0c92d0b74f97406b2
  Author: Simon Wilkinson <sxw at auristor.com>
  Date:   2018-09-18 (Tue, 18 Sep 2018)

  Changed paths:
    M lib/gssapi/test_context.c
    M lib/krb5/crypto-evp.c

  Log Message:
  -----------
  Allow zero-length encrypt IOVs in _krb5_evp_encrypt_iov_cts()

The iovec encryption code doesn't handle 0 length iovecs correctly.
Instead of just skipping them, _krb5_evp_encrypt_iov_cts() will spin
on the 0 length iovec.

Modify the _krb5_evp_iov_cursor_expand helper so that iovec expansion
simply skips 0 length iovecs, and make _krb5_evp_iov_cursor_nextcrypt
do the same.

Original bug report and tests from Andrew Bartlett <abartlet at samba.org>



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From noreply at github.com  Wed Sep 19 01:23:56 2018
From: noreply at github.com (GitHub)
Date: Tue, 18 Sep 2018 16:23:56 -0700
Subject: [Heimdal-source-changes] [heimdal/heimdal]
Message-ID: <5ba1890c2e108_654a2ab81cd3aec4433c3@hookshot-fe-da92815.cp1-iad.github.net.mail>

  Branch: refs/heads/sxw/iovec-more-fixes
  Home:   https://github.com/heimdal/heimdal

      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From noreply at github.com  Wed Sep 19 03:59:55 2018
From: noreply at github.com (GitHub)
Date: Tue, 18 Sep 2018 18:59:55 -0700
Subject: [Heimdal-source-changes] [heimdal/heimdal] 8c2a52: lib/kadm5:
 improve kadm_c_ error handling
Message-ID: <5ba1ad9be7e48_4f892aaf7498eed441240@hookshot-fe-b0febf1.cp1-iad.github.net.mail>

  Branch: refs/heads/jaltman/kadm_c_error_handling
  Home:   https://github.com/heimdal/heimdal
  Commit: 8c2a52a943590d239924f8448caea1eda331ef68
      https://github.com/heimdal/heimdal/commit/8c2a52a943590d239924f8448caea1eda331ef68
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2018-09-18 (Tue, 18 Sep 2018)

  Changed paths:
    M lib/kadm5/chpass_c.c
    M lib/kadm5/create_c.c
    M lib/kadm5/delete_c.c
    M lib/kadm5/get_c.c
    M lib/kadm5/get_princs_c.c
    M lib/kadm5/modify_c.c
    M lib/kadm5/privs_c.c
    M lib/kadm5/randkey_c.c
    M lib/kadm5/rename_c.c

  Log Message:
  -----------
  lib/kadm5: improve kadm_c_ error handling

Perform error checking for each function call and consistently return
errors at the point of failure.

Refactor functions to use a common exit path.  Preserve error messages
stored in the kadm5_client_context.context when appropriate.

Change-Id: I7aa04020e4de3454066f0d88ba805fed999dbd1a



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From noreply at github.com  Wed Sep 19 05:46:09 2018
From: noreply at github.com (GitHub)
Date: Tue, 18 Sep 2018 20:46:09 -0700
Subject: [Heimdal-source-changes] [heimdal/heimdal] fefade: roken:
 gettimeofday using GetSystemTimePreciseAsFi...
Message-ID: <5ba1c6811c958_163e2abf5efdaec4410bc@hookshot-fe-d252ca1.cp1-iad.github.net.mail>

  Branch: refs/heads/jaltman/roken_gettimeofday
  Home:   https://github.com/heimdal/heimdal
  Commit: fefade0f766aab97644823200da51680eb76fd68
      https://github.com/heimdal/heimdal/commit/fefade0f766aab97644823200da51680eb76fd68
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2018-09-18 (Tue, 18 Sep 2018)

  Changed paths:
    M lib/roken/gettimeofday.c

  Log Message:
  -----------
  roken: gettimeofday using GetSystemTimePreciseAsFileTime

GetSystemTimeAsFileTime() has 16ms precision.

GetSystemTimePreciseAsFileTime() has <1ns precision but is only available
on Windows 8 or later.

This change dynamically loads GetSystemTimePreciseAsFileTime() if it is
available.

Change-Id: Ib9c616c01948384e6b256ac9b6023f1e39673613



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From noreply at github.com  Wed Sep 19 06:30:44 2018
From: noreply at github.com (GitHub)
Date: Tue, 18 Sep 2018 21:30:44 -0700
Subject: [Heimdal-source-changes] [heimdal/heimdal] 1feff8: roken:
 gettimeofday using GetSystemTimePreciseAsFi...
Message-ID: <5ba1d0f43812e_1d2572abc29ab6ed096815@hookshot-fe-dfcc362.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: 1feff82129fb1f64934559e3c209928033c632fe
      https://github.com/heimdal/heimdal/commit/1feff82129fb1f64934559e3c209928033c632fe
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2018-09-19 (Wed, 19 Sep 2018)

  Changed paths:
    M lib/roken/gettimeofday.c

  Log Message:
  -----------
  roken: gettimeofday using GetSystemTimePreciseAsFileTime

GetSystemTimeAsFileTime() has 16ms precision.

GetSystemTimePreciseAsFileTime() has <1ns precision but is only available
on Windows 8 or later.

This change dynamically loads GetSystemTimePreciseAsFileTime() if it is
available.

Change-Id: Ib9c616c01948384e6b256ac9b6023f1e39673613



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From noreply at github.com  Wed Sep 19 06:30:50 2018
From: noreply at github.com (GitHub)
Date: Tue, 18 Sep 2018 21:30:50 -0700
Subject: [Heimdal-source-changes] [heimdal/heimdal]
Message-ID: <5ba1d0fa6ccb3_57d02b25fea7aec82792@hookshot-fe-2cc8887.cp1-iad.github.net.mail>

  Branch: refs/heads/jaltman/roken_gettimeofday
  Home:   https://github.com/heimdal/heimdal

      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From noreply at github.com  Sat Sep 22 19:25:02 2018
From: noreply at github.com (GitHub)
Date: Sat, 22 Sep 2018 10:25:02 -0700
Subject: [Heimdal-source-changes] [heimdal/heimdal] 56fe2f: Clear DES key
 (schedule) in unwrap BAD_MIC case
Message-ID: <5ba67aee1bee5_2fef2ad285274ed0146a4@hookshot-fe-dfcc362.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: 56fe2f86206be60200542e9668c400a8767ea2e9
      https://github.com/heimdal/heimdal/commit/56fe2f86206be60200542e9668c400a8767ea2e9
  Author: Benjamin Kaduk <kaduk at mit.edu>
  Date:   2018-09-22 (Sat, 22 Sep 2018)

  Changed paths:
    M lib/gssapi/krb5/unwrap.c

  Log Message:
  -----------
  Clear DES key (schedule) in unwrap BAD_MIC case

We generally clear out the cryptographic key and key schedule from
local variables before relinquishing control flow, but this case was
missed.  Reported by jhb at FreeBSD.org.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From noreply at github.com  Wed Sep 26 21:52:17 2018
From: noreply at github.com (GitHub)
Date: Wed, 26 Sep 2018 12:52:17 -0700
Subject: [Heimdal-source-changes] [heimdal/heimdal] a951e4: lib/kadm5:
 kadmin hook_libraries plugin interface
Message-ID: <5babe371e24f9_76ca2ab1a1cf0ecc69680@hookshot-fe-31feec6.cp1-iad.github.net.mail>

  Branch: refs/heads/jaltman/krb5-sync
  Home:   https://github.com/heimdal/heimdal
  Commit: a951e48e123dab1583ae711bb26ee612ba4409ad
      https://github.com/heimdal/heimdal/commit/a951e48e123dab1583ae711bb26ee612ba4409ad
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2018-09-26 (Wed, 26 Sep 2018)

  Changed paths:
    A lib/kadm5/kadm5-hook.h
    A lib/kadm5/server_hooks.c

  Log Message:
  -----------
  lib/kadm5: kadmin hook_libraries plugin interface

This change adds plugin support to the kadmin libraries for performing
actions before and after a password change is committed to the KDC database
and after a change is made to the attributes of a principal (specifically,
a change to DISALLOW_ALL_TIX).

This change adds a hook_libraries configuration option to the [kadmin]
section of krb5.conf (or kdc.conf if you use that file) that must be set
to load the module.  That configuration option is in the form:

    [kadmin]
      hook_libraries = /usr/local/lib/krb5/plugins/kadm5_hook/krb5_sync.so

where the value is the full path to the plugin that you want to load.  If
this option is not present, kadmind will not load a plugin and the changes
from the patch will be inactive.  If this option is given and the plugin
cannot be loaded, kadmind startup will abort with a (hopefully useful)
error message in syslog.

Any plugin used with this patch must expose a public struct named
kadm5_hook.  That struct must contain the following:

    typedef struct kadm5_hook {
  const char *name;
  int version;
  const char *vendor;
   krb5_error_code (*init)(krb5_context, void **);
  void (*fini)(krb5_context, void *);
   krb5_error_code (*chpass)(krb5_context, void *, enum kadm5_hook_stage,
                            krb5_principal, const char *);
  krb5_error_code (*create)(krb5_context, void *, enum kadm5_hook_stage,
                            kadm5_principal_ent_t, uint32_t mask,
                            const char *password);
  krb5_error_code (*modify)(krb5_context, void *, enum kadm5_hook_stage,
                            kadm5_principal_ent_t, uint32_t mask);
    } kadm5_hook;

where enum kadm5_hook_stage is:

    enum kadm5_hook_stage {
  KADM5_HOOK_STAGE_PRECOMMIT,
  KADM5_HOOK_STAGE_POSTCOMMIT
    };

init creates a hook context that is passed into all subsequent calls.
chpass is called for password changes, create is called for principal
creation (with the newly-created principal in the kadm5_principal_ent_t
argument), and modify is called when a principal is modified.

These functions should follow the normal Kerberos calling convention of
returning 0 on success and a Kerberos error code on failure, setting the
Kerberos error message in the provided context.

This change is submitted under the following license

  Copyright 2012, 2013
    The Board of Trustees of the Leland Stanford Junior University

  Copying and distribution of this file, with or without modification, are
  permitted in any medium without royalty provided the copyright notice and
  this notice are preserved.  This file is offered as-is, without any
  warranty.

Change-Id: Iebf2c0ac5767f79fe72cc4a1c74521f3cb790d12



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.