[Heimdal-source-changes] [heimdal/heimdal] fb9a78: We stop strnvisx(3)ing logs to FILE: by default.

[Roland C. Dowdeswell]

  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: fb9a78223c5a481630436ac80c95eecaced4a153
      https://github.com/heimdal/heimdal/commit/fb9a78223c5a481630436ac80c95eecaced4a153
  Author: Roland C. Dowdeswell <roland.dowdeswell at twosigma.com>
  Date:   2019-12-05 (Thu, 05 Dec 2019)

  Changed paths:
    M lib/krb5/log.c

  Log Message:
  -----------
  We stop strnvisx(3)ing logs to FILE: by default.

Our logging framework used to strnvisx(3) each and every line
iff it is written to a FILE.  This is often unhelpful because
the line usually contains a number of elements that have already
been quoted and it makes the logs much more difficult to read in
this case.  An example if krb5_unparse_name() which will already
quote most characters that one cares about.

We change the behaviour to simply drop unprintable characters
rather than encoding them.  We thus rely on the rest of the
code to properly encode data elements written into the logs.


  Commit: 7d353d05570e5be3def8341d54e18e49f91b130b
      https://github.com/heimdal/heimdal/commit/7d353d05570e5be3def8341d54e18e49f91b130b
  Author: Roland C. Dowdeswell <roland.dowdeswell at twosigma.com>
  Date:   2019-12-05 (Thu, 05 Dec 2019)

  Changed paths:
    M kdc/digest-service.c
    M kdc/fast.c
    M kdc/kdc.h
    M kdc/kdc_locl.h
    M kdc/kerberos5.c
    M kdc/krb5tgs.c
    M kdc/pkinit.c
    M kdc/process.c
    M kdc/windc.c

  Log Message:
  -----------
  Generate a single summary audit line for AS/TGS.

We refactor the code a bit to extend kdc_request_t which until now
was only used for the AS.  We make the structure extensible and
start using it for the TGS as well.  We leave digest and kx509
alone for the time being.

We also define the concept of kv-pairs in our audit trail which
allows us to define a rigorous but extensible format:

type error from-addr client server key1=val1 key2=val2 ...


  Commit: 6db323157f533bc89c81a75c7307843c470806bd
      https://github.com/heimdal/heimdal/commit/6db323157f533bc89c81a75c7307843c470806bd
  Author: Roland C. Dowdeswell <roland.dowdeswell at twosigma.com>
  Date:   2019-12-05 (Thu, 05 Dec 2019)

  Changed paths:
    M kdc/kerberos5.c
    M kdc/krb5tgs.c
    M kdc/windc.c

  Log Message:
  -----------
  Reduce older log messages to level 4 and collect some errors.

We take all of the kdc_log() and _kdc_r_log() calls in AS and TGS
and move their log levels down to debugging on the assumption that
our new log line subsumes the "informational" requirements.  We
collect some additional information in the kv-pair "pe-text" which
is like e-text except it is not returned to the client.


  Commit: c76e30e90cf9f2dfc4fadf73ba7944f325ade81d
      https://github.com/heimdal/heimdal/commit/c76e30e90cf9f2dfc4fadf73ba7944f325ade81d
  Author: Roland C. Dowdeswell <roland.dowdeswell at twosigma.com>
  Date:   2019-12-05 (Thu, 05 Dec 2019)

  Changed paths:
    M lib/krb5/krb5_openlog.3

  Log Message:
  -----------
  Document that log level 7 is for tracing.


  Commit: 430e18c0741f5e86982289c521b028d3867ceb06
      https://github.com/heimdal/heimdal/commit/430e18c0741f5e86982289c521b028d3867ceb06
  Author: Roland C. Dowdeswell <roland.dowdeswell at twosigma.com>
  Date:   2019-12-05 (Thu, 05 Dec 2019)

  Changed paths:
    M kdc/kdc.h
    M kdc/process.c

  Log Message:
  -----------
  kdc/process.c: add tracing messages.


  Commit: 05e851754291c735d387a5d92859d90ea2edc8bc
      https://github.com/heimdal/heimdal/commit/05e851754291c735d387a5d92859d90ea2edc8bc
  Author: Roland C. Dowdeswell <roland.dowdeswell at twosigma.com>
  Date:   2019-12-05 (Thu, 05 Dec 2019)

  Changed paths:
    M kdc/fast.c

  Log Message:
  -----------
  kdc/fast.c: fix leak in unusual error path.


  Commit: 001e312ba5e7972b403e6b403b78bd53c22d8b80
      https://github.com/heimdal/heimdal/commit/001e312ba5e7972b403e6b403b78bd53c22d8b80
  Author: Roland C. Dowdeswell <roland.dowdeswell at twosigma.com>
  Date:   2019-12-05 (Thu, 05 Dec 2019)

  Changed paths:
    M lib/krb5/cache.c

  Log Message:
  -----------
  Make krb5_cc_close(ctx, NULL) stop SEGV'ing.


Compare: https://github.com/heimdal/heimdal/compare/575c67806be9...001e312ba5e7