[Heimdal-source-changes] [heimdal/heimdal] 17103b: lib/krb5: krb5.h missing KRB5_LIB_CALL definition

[Jeffrey Altman]

  Branch: refs/heads/jaltman/plugin-fixes
  Home:   https://github.com/heimdal/heimdal
  Commit: 17103b2b5e9c40a2ff5ce649ae8aaab04f91a65e
      https://github.com/heimdal/heimdal/commit/17103b2b5e9c40a2ff5ce649ae8aaab04f91a65e
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2019-02-21 (Thu, 21 Feb 2019)

  Changed paths:
    M lib/krb5/krb5.h

  Log Message:
  -----------
  lib/krb5: krb5.h missing KRB5_LIB_CALL definition

KRB5_LIB_CALL must be defined for out of tree users.

Change-Id: I10a02fdca3ed64093fabd8d391761448b9c480a5


  Commit: 060e7dd8fae7d926e062b4de7d54b019c3016848
      https://github.com/heimdal/heimdal/commit/060e7dd8fae7d926e062b4de7d54b019c3016848
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2019-02-21 (Thu, 21 Feb 2019)

  Changed paths:
    M lib/krb5/krb5.h

  Log Message:
  -----------
  lib/krb5: fix krb5_get_instance_func_t prototype

KRB5_LIB_CALL not KRB5_CALLCONV

Change-Id: I31b8750d63849c2f5cce49642a63fd66e7fa1a32


  Commit: a47316ad94a3f868c61b9144116d461d9c404cfe
      https://github.com/heimdal/heimdal/commit/a47316ad94a3f868c61b9144116d461d9c404cfe
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2019-02-21 (Thu, 21 Feb 2019)

  Changed paths:
    M lib/krb5/plugin.c

  Log Message:
  -----------
  lib/krb5: common plugin only fallback if load_fn() fails

Only fallback to loading the plugin function table directly if
if the initialization function is not exported.  Failing a
consistency check should not permit falling back to a potentially
incompatible function table.

Change-Id: Ic753ed9a090aef6073853f7309f0f8f0f29d0aa9


  Commit: cdf520156833c7b7504bc5fb42952271a40629c0
      https://github.com/heimdal/heimdal/commit/cdf520156833c7b7504bc5fb42952271a40629c0
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2019-02-21 (Thu, 21 Feb 2019)

  Changed paths:
    M lib/krb5/plugin.c

  Log Message:
  -----------
  lib/krb5: common_plugin_ftable_desc funcs KRB5_LIB_CALL

As with the krb5plugin_an2ln_ftable_desc, krb5plugin_db_ftable_desc,
and krb5plugin_kuserok_ftable_desc the function pointers in
common_plugin_ftable_desc must be annotated with KRB5_LIB_CALL.

Change-Id: Ia7ea78743ee9eb8c7f6b648063852ca91a360d2c


  Commit: 0705d6aeaedc0c5c309ad75bb99c3696f0a93685
      https://github.com/heimdal/heimdal/commit/0705d6aeaedc0c5c309ad75bb99c3696f0a93685
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2019-02-21 (Thu, 21 Feb 2019)

  Changed paths:
    M lib/krb5/ccache_plugin.h
    A lib/krb5/common_plugin.h
    M lib/krb5/plugin.c

  Log Message:
  -----------
  lib/krb5: prepare to make common plugins public

Rename common_plugin_ftable to krb5_plugin_common_ftable.

Create lib/krb5/common_plugin.h to include the structure and typedef.

The common_plugin.h header is now included by ccache_plugin.h
along with a prototype for the required ccache_ops_plugin_load()
function.

Change-Id: I2b27d6d0f5cf0544482c3f01784fef945e12e8d8


  Commit: 61640e602bdfd583fa0b90d42c2c0e58bada51d0
      https://github.com/heimdal/heimdal/commit/61640e602bdfd583fa0b90d42c2c0e58bada51d0
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2019-02-21 (Thu, 21 Feb 2019)

  Changed paths:
    M lib/krb5/ccache_plugin.h
    M lib/krb5/common_plugin.h
    M lib/krb5/plugin.c

  Log Message:
  -----------
  lib/krb5: prevent build failures of krb5_plugin_common on Windows

The Microsoft compiler cannot handle multiple const modifiers
for the same type.    It is also unhappy with the output pointer
parameter being declared const.

This change introduces new typedefs and cast of the dlsym() return
type to prevent warnings.

Change-Id: Ia92645efab8d2ec6745339a6f47c690782ae730a


  Commit: a51b3cb6ae20abbfae4c5b12e88ed3edb57f0ec8
      https://github.com/heimdal/heimdal/commit/a51b3cb6ae20abbfae4c5b12e88ed3edb57f0ec8
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2019-02-21 (Thu, 21 Feb 2019)

  Changed paths:
    M lib/krb5/Makefile.am
    M lib/krb5/NTMakefile

  Log Message:
  -----------
  lib/krb5: add plugin headers to Makefiles

Change-Id: I6701035da2e7ff3f83feee6cbb4921e5bd5dfd75


Compare: https://github.com/heimdal/heimdal/compare/17103b2b5e9c%5E...a51b3cb6ae20