From noreply at github.com Tue Jan 1 09:06:28 2019 From: noreply at github.com (GitHub) Date: Tue, 01 Jan 2019 00:06:28 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] b9dcbe: Windows: default client keytab to %{LOCAL_APPDATA}... Message-ID: <5c2b1f84be538_23112af25334e570673c1@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: b9dcbe505dcbc2e6588e700f55b8af40557e0a86 https://github.com/heimdal/heimdal/commit/b9dcbe505dcbc2e6588e700f55b8af40557e0a86 Author: Luke Howard Date: 2019-01-01 (Tue, 01 Jan 2019) Changed paths: M include/config.h.w32 Log Message: ----------- Windows: default client keytab to %{LOCAL_APPDATA}/Kerberos/client.keytab Commit: 7098aa038b1946fd221a95daed47e051e8516486 https://github.com/heimdal/heimdal/commit/7098aa038b1946fd221a95daed47e051e8516486 Author: Luke Howard Date: 2019-01-01 (Tue, 01 Jan 2019) Changed paths: M include/config.h.w32 Log Message: ----------- Windows: remove reference to NetInfo Compare: https://github.com/heimdal/heimdal/compare/f3f06fcba906...7098aa038b19 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Tue Jan 1 21:00:32 2019 From: noreply at github.com (GitHub) Date: Tue, 01 Jan 2019 12:00:32 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] c1c98d: lib/roken: is_special_auxv_p test for AT_HWCAP2 Message-ID: <5c2bc6e055617_61e92b0e8baea578619a@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: c1c98d3cfd42600e1bb3746b6ed090ab12bb4559 https://github.com/heimdal/heimdal/commit/c1c98d3cfd42600e1bb3746b6ed090ab12bb4559 Author: Jeffrey Altman Date: 2019-01-01 (Tue, 01 Jan 2019) Changed paths: M lib/roken/test-auxval.c Log Message: ----------- lib/roken: is_special_auxv_p test for AT_HWCAP2 fix breakage introduced by 63411321753e1ee959fd1e69ba5986d2438f1b39 ("roken: fix build breakage, AT_HWCAP2 may be undefined (#446)"). Detected by Coverity. Change-Id: Iefdb73d4392e5184a69a99208945ece6b7b8ecb3 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Tue Jan 1 21:06:58 2019 From: noreply at github.com (GitHub) Date: Tue, 01 Jan 2019 12:06:58 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] da6190: lib/gssapi/ntlm: _gss_ntlm_allocate_ctx handle cal... Message-ID: <5c2bc862b56d4_19d2b2599bec5784993b@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: da6190ec033fa9790f0bc235c433464a11f5a1f4 https://github.com/heimdal/heimdal/commit/da6190ec033fa9790f0bc235c433464a11f5a1f4 Author: Jeffrey Altman Date: 2019-01-01 (Tue, 01 Jan 2019) Changed paths: M lib/gssapi/ntlm/accept_sec_context.c Log Message: ----------- lib/gssapi/ntlm: _gss_ntlm_allocate_ctx handle calloc failure If a memory allocation failure occurs, return an error instead of triggering a segmentation fault. Change-Id: I38f5e88ca2f1ba7411b05a35b925168015261eb4 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Wed Jan 2 04:38:28 2019 From: noreply at github.com (GitHub) Date: Tue, 01 Jan 2019 19:38:28 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 92efcf: WIN32: hint noreturn functions Message-ID: <5c2c32345f5a7_66b72b1ce12ba5881401e0@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/jaltman/win32-noreturn Home: https://github.com/heimdal/heimdal Commit: 92efcf255efee2e168402e11aedb902b1bbcb8b9 https://github.com/heimdal/heimdal/commit/92efcf255efee2e168402e11aedb902b1bbcb8b9 Author: Jeffrey Altman Date: 2019-01-01 (Tue, 01 Jan 2019) Changed paths: M cf/make-proto.pl M include/config.h.w32 M lib/hx509/cert.c M lib/krb5/warn.c M lib/roken/err.hin M lib/roken/errx.c M lib/roken/roken.h.in M lib/roken/verrx.c Log Message: ----------- WIN32: hint noreturn functions apply __declspec(noreturn) compiler hints to functions that do not return. Change-Id: I3c6c4703c7235d1df3e21dccad5272ea4cddfd36 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Wed Jan 2 04:58:54 2019 From: noreply at github.com (GitHub) Date: Tue, 01 Jan 2019 19:58:54 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 508259: WIN32: hint noreturn functions Message-ID: <5c2c36fe6aeb5_1e0b2abdb9ad458451347@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/jaltman/win32-noreturn Home: https://github.com/heimdal/heimdal Commit: 5082594cc3790a2ea2c8c5ad70566ccc6f1c4169 https://github.com/heimdal/heimdal/commit/5082594cc3790a2ea2c8c5ad70566ccc6f1c4169 Author: Jeffrey Altman Date: 2019-01-01 (Tue, 01 Jan 2019) Changed paths: M cf/make-proto.pl M include/config.h.w32 M lib/hx509/cert.c M lib/krb5/warn.c M lib/roken/err.hin M lib/roken/errx.c M lib/roken/roken.h.in M lib/roken/verrx.c Log Message: ----------- WIN32: hint noreturn functions apply __declspec(noreturn) compiler hints to functions that do not return. Change-Id: I3c6c4703c7235d1df3e21dccad5272ea4cddfd36 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Wed Jan 2 06:18:32 2019 From: noreply at github.com (GitHub) Date: Tue, 01 Jan 2019 21:18:32 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 2f8371: WIN32: hint noreturn functions Message-ID: <5c2c49a88d845_22462b08c9f1257858744@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/jaltman/win32-noreturn Home: https://github.com/heimdal/heimdal Commit: 2f8371bc3dbb4f1813a39a0cc32840e742f1a56f https://github.com/heimdal/heimdal/commit/2f8371bc3dbb4f1813a39a0cc32840e742f1a56f Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M cf/make-proto.pl M include/config.h.w32 M lib/krb5/warn.c M lib/roken/err.hin M lib/roken/errx.c M lib/roken/roken.h.in M lib/roken/verrx.c Log Message: ----------- WIN32: hint noreturn functions apply __declspec(noreturn) compiler hints to functions that do not return. Change-Id: I3c6c4703c7235d1df3e21dccad5272ea4cddfd36 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Wed Jan 2 14:35:40 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 05:35:40 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] a010e6: lib/wind: get-punycode-examples.py whitespace fix Message-ID: <5c2cbe2cc5a1e_3c262ae005fd058851042@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/jaltman/win32-noreturn Home: https://github.com/heimdal/heimdal Commit: a010e65c8ca1b697ee04e629fece90837e2f1e41 https://github.com/heimdal/heimdal/commit/a010e65c8ca1b697ee04e629fece90837e2f1e41 Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/wind/gen-punycode-examples.py Log Message: ----------- lib/wind: get-punycode-examples.py whitespace fix Change-Id: I89e82539578fd9436ee735c124401fa019369eee Commit: ef38cecfd7d623dc27f7f92c8d48b1d5a5112efb https://github.com/heimdal/heimdal/commit/ef38cecfd7d623dc27f7f92c8d48b1d5a5112efb Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M cf/make-proto.pl M include/config.h.w32 M lib/krb5/warn.c M lib/roken/err.hin M lib/roken/errx.c M lib/roken/roken.h.in M lib/roken/verrx.c Log Message: ----------- WIN32: hint noreturn functions apply __declspec(noreturn) compiler hints to functions that do not return. Change-Id: I3c6c4703c7235d1df3e21dccad5272ea4cddfd36 Commit: 1586ca1dc4fede1f582fd89ea34e9255195e1726 https://github.com/heimdal/heimdal/commit/1586ca1dc4fede1f582fd89ea34e9255195e1726 Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M include/config.h.w32 M lib/hx509/NTMakefile M lib/hx509/ca.c M lib/hx509/cert.c M lib/hx509/cms.c M lib/hx509/collector.c M lib/hx509/crypto-ec.c M lib/hx509/crypto.c M lib/hx509/env.c M lib/hx509/error.c M lib/hx509/file.c M lib/hx509/keyset.c M lib/hx509/ks_dir.c M lib/hx509/ks_file.c M lib/hx509/ks_keychain.c M lib/hx509/ks_mem.c M lib/hx509/ks_null.c M lib/hx509/ks_p11.c M lib/hx509/ks_p12.c M lib/hx509/lock.c M lib/hx509/name.c M lib/hx509/peer.c M lib/hx509/print.c M lib/hx509/req.c M lib/hx509/revoke.c M lib/hx509/sel.c Log Message: ----------- lib/hx509: declare and apply HX509_LIB_xxx macros libhx509 is not built according to the same export and calling conventions on Windows as the other libraries. This change declares and applies HX509_LIB_FUNCTION, HX509_LIB_NORETURN_FUNCTION, HX509_LIB_CALL and HX509_LIB_VARIABLE to lib/hx509. As a result of this change the calling convention for exported functions will be __stdcall instead of __cdecl. Change-Id: Ibc3f05e8088030ef7d13798f1d9c9b190bc57797 Compare: https://github.com/heimdal/heimdal/compare/2f8371bc3dbb...1586ca1dc4fe **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Wed Jan 2 15:18:02 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 06:18:02 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] e757ff: lib/hx509: declare and apply HX509_LIB_xxx macros Message-ID: <5c2cc81a48fa3_4e812b23ae072590112341@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/jaltman/win32-noreturn Home: https://github.com/heimdal/heimdal Commit: e757ffff3fe58257f9d786a2ad213936851f0c11 https://github.com/heimdal/heimdal/commit/e757ffff3fe58257f9d786a2ad213936851f0c11 Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M include/config.h.w32 M lib/hx509/NTMakefile M lib/hx509/ca.c M lib/hx509/cert.c M lib/hx509/cms.c M lib/hx509/collector.c M lib/hx509/crypto-ec.c M lib/hx509/crypto.c M lib/hx509/env.c M lib/hx509/error.c M lib/hx509/file.c M lib/hx509/keyset.c M lib/hx509/ks_dir.c M lib/hx509/ks_file.c M lib/hx509/ks_keychain.c M lib/hx509/ks_mem.c M lib/hx509/ks_null.c M lib/hx509/ks_p11.c M lib/hx509/ks_p12.c M lib/hx509/lock.c M lib/hx509/name.c M lib/hx509/peer.c M lib/hx509/print.c M lib/hx509/req.c M lib/hx509/revoke.c M lib/hx509/sel.c Log Message: ----------- lib/hx509: declare and apply HX509_LIB_xxx macros libhx509 is not built according to the same export and calling conventions on Windows as the other libraries. This change declares and applies HX509_LIB_FUNCTION, HX509_LIB_NORETURN_FUNCTION, HX509_LIB_CALL and HX509_LIB_VARIABLE to lib/hx509. As a result of this change the calling convention for exported functions will be __stdcall instead of __cdecl. Change-Id: Ibc3f05e8088030ef7d13798f1d9c9b190bc57797 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Wed Jan 2 15:59:16 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 06:59:16 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] ef038c: lib/hx509: conditionally define __attribute(X) in ... Message-ID: <5c2cd1c462f65_20bb2ac211b9857c442d4@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/jaltman/win32-noreturn Home: https://github.com/heimdal/heimdal Commit: ef038c65e33742122a0373102e5f42db5bb86f7e https://github.com/heimdal/heimdal/commit/ef038c65e33742122a0373102e5f42db5bb86f7e Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/hx509/cert.c Log Message: ----------- lib/hx509: conditionally define __attribute(X) in cert.c At the moment the noreturn attribute on _hx509_abort() is unconditionally ignored due to an unconditional "#undef __attribute / #define __attribute__(X)" pair that was introduced as part of a 3be06f138fb06fb5b22b6dbea4a1ea7634c08932 ("Provide __attribute__ for _hx509_abort.") Change-Id: I1e4d24d2dbefdae38cf41a5507ed417aa09cf9b8 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Wed Jan 2 16:12:45 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 07:12:45 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] Message-ID: <5c2cd4edbe76b_19ba2aed298325845279f@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/jaltman/win32-noreturn Home: https://github.com/heimdal/heimdal **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Wed Jan 2 16:48:15 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 07:48:15 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 285794: WIN32: hint noreturn functions Message-ID: <5c2cdd3fc4e48_d002b24c4ed8578392f2@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/jaltman/win32-noreturn Home: https://github.com/heimdal/heimdal Commit: 285794bdf537353c79957f7f3d17e251aa76966c https://github.com/heimdal/heimdal/commit/285794bdf537353c79957f7f3d17e251aa76966c Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M cf/make-proto.pl M include/config.h.w32 M lib/krb5/warn.c M lib/roken/err.hin M lib/roken/errx.c M lib/roken/roken.h.in M lib/roken/verrx.c Log Message: ----------- WIN32: hint noreturn functions apply __declspec(noreturn) compiler hints to functions that do not return. Change-Id: I3c6c4703c7235d1df3e21dccad5272ea4cddfd36 Commit: a2212f293e733e6e06ea6d27d63cfa2712a389ea https://github.com/heimdal/heimdal/commit/a2212f293e733e6e06ea6d27d63cfa2712a389ea Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M include/config.h.w32 M lib/hx509/NTMakefile M lib/hx509/ca.c M lib/hx509/cert.c M lib/hx509/cms.c M lib/hx509/collector.c M lib/hx509/crypto-ec.c M lib/hx509/crypto.c M lib/hx509/env.c M lib/hx509/error.c M lib/hx509/file.c M lib/hx509/keyset.c M lib/hx509/ks_dir.c M lib/hx509/ks_file.c M lib/hx509/ks_keychain.c M lib/hx509/ks_mem.c M lib/hx509/ks_null.c M lib/hx509/ks_p11.c M lib/hx509/ks_p12.c M lib/hx509/lock.c M lib/hx509/name.c M lib/hx509/peer.c M lib/hx509/print.c M lib/hx509/req.c M lib/hx509/revoke.c M lib/hx509/sel.c Log Message: ----------- lib/hx509: declare and apply HX509_LIB_xxx macros libhx509 is not built according to the same export and calling conventions on Windows as the other libraries. This change declares and applies HX509_LIB_FUNCTION, HX509_LIB_NORETURN_FUNCTION, HX509_LIB_CALL and HX509_LIB_VARIABLE to lib/hx509. As a result of this change the calling convention for exported functions will be __stdcall instead of __cdecl. Change-Id: Ibc3f05e8088030ef7d13798f1d9c9b190bc57797 Compare: https://github.com/heimdal/heimdal/compare/e757ffff3fe5...a2212f293e73 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Wed Jan 2 17:04:10 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 08:04:10 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 73915c: WIN32: hint noreturn functions Message-ID: <5c2ce0fa63e2b_28312ab80e4da5941180a7@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/jaltman/win32-noreturn Home: https://github.com/heimdal/heimdal Commit: 73915ccbf9863e734aaa596d0db3c5954673f6b0 https://github.com/heimdal/heimdal/commit/73915ccbf9863e734aaa596d0db3c5954673f6b0 Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M cf/make-proto.pl M include/config.h.w32 M lib/krb5/warn.c M lib/roken/err.hin M lib/roken/errx.c M lib/roken/roken.h.in M lib/roken/verrx.c Log Message: ----------- WIN32: hint noreturn functions apply __declspec(noreturn) compiler hints to functions that do not return. Change-Id: I3c6c4703c7235d1df3e21dccad5272ea4cddfd36 Commit: c3665001b3e598defa48e5b516fa65cd40667cf3 https://github.com/heimdal/heimdal/commit/c3665001b3e598defa48e5b516fa65cd40667cf3 Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M include/config.h.w32 M lib/hx509/NTMakefile M lib/hx509/ca.c M lib/hx509/cert.c M lib/hx509/cms.c M lib/hx509/collector.c M lib/hx509/crypto-ec.c M lib/hx509/crypto.c M lib/hx509/env.c M lib/hx509/error.c M lib/hx509/file.c M lib/hx509/keyset.c M lib/hx509/ks_dir.c M lib/hx509/ks_file.c M lib/hx509/ks_keychain.c M lib/hx509/ks_mem.c M lib/hx509/ks_null.c M lib/hx509/ks_p11.c M lib/hx509/ks_p12.c M lib/hx509/lock.c M lib/hx509/name.c M lib/hx509/peer.c M lib/hx509/print.c M lib/hx509/req.c M lib/hx509/revoke.c M lib/hx509/sel.c Log Message: ----------- lib/hx509: declare and apply HX509_LIB_xxx macros libhx509 is not built according to the same export and calling conventions on Windows as the other libraries. This change declares and applies HX509_LIB_FUNCTION, HX509_LIB_NORETURN_FUNCTION, HX509_LIB_CALL and HX509_LIB_VARIABLE to lib/hx509. As a result of this change the calling convention for exported functions will be __stdcall instead of __cdecl. Change-Id: Ibc3f05e8088030ef7d13798f1d9c9b190bc57797 Compare: https://github.com/heimdal/heimdal/compare/a2212f293e73...c3665001b3e5 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Wed Jan 2 17:23:41 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 08:23:41 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 4d57ee: lib/wind: get-punycode-examples.py whitespace fix Message-ID: <5c2ce58d81740_3a522b116d098590813b@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 4d57ee72f322352c19497bdea1849b42034cb2a2 https://github.com/heimdal/heimdal/commit/4d57ee72f322352c19497bdea1849b42034cb2a2 Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/wind/gen-punycode-examples.py Log Message: ----------- lib/wind: get-punycode-examples.py whitespace fix Change-Id: I89e82539578fd9436ee735c124401fa019369eee Commit: bec4818943c8d5cbf8e7db9dfd8db037c8645d80 https://github.com/heimdal/heimdal/commit/bec4818943c8d5cbf8e7db9dfd8db037c8645d80 Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M cf/make-proto.pl M include/config.h.w32 M lib/krb5/warn.c M lib/roken/err.hin M lib/roken/errx.c M lib/roken/roken.h.in M lib/roken/verrx.c Log Message: ----------- WIN32: hint noreturn functions apply __declspec(noreturn) compiler hints to functions that do not return. Change-Id: I3c6c4703c7235d1df3e21dccad5272ea4cddfd36 Commit: 1dd38cc3de956a52b33a4ada57e9a7c5b1e4049f https://github.com/heimdal/heimdal/commit/1dd38cc3de956a52b33a4ada57e9a7c5b1e4049f Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M include/config.h.w32 M lib/hx509/NTMakefile M lib/hx509/ca.c M lib/hx509/cert.c M lib/hx509/cms.c M lib/hx509/collector.c M lib/hx509/crypto-ec.c M lib/hx509/crypto.c M lib/hx509/env.c M lib/hx509/error.c M lib/hx509/file.c M lib/hx509/keyset.c M lib/hx509/ks_dir.c M lib/hx509/ks_file.c M lib/hx509/ks_keychain.c M lib/hx509/ks_mem.c M lib/hx509/ks_null.c M lib/hx509/ks_p11.c M lib/hx509/ks_p12.c M lib/hx509/lock.c M lib/hx509/name.c M lib/hx509/peer.c M lib/hx509/print.c M lib/hx509/req.c M lib/hx509/revoke.c M lib/hx509/sel.c Log Message: ----------- lib/hx509: declare and apply HX509_LIB_xxx macros libhx509 is not built according to the same export and calling conventions on Windows as the other libraries. This change declares and applies HX509_LIB_FUNCTION, HX509_LIB_NORETURN_FUNCTION, HX509_LIB_CALL and HX509_LIB_VARIABLE to lib/hx509. As a result of this change the calling convention for exported functions will be __stdcall instead of __cdecl. Change-Id: Ibc3f05e8088030ef7d13798f1d9c9b190bc57797 Compare: https://github.com/heimdal/heimdal/compare/da6190ec033f...1dd38cc3de95 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Wed Jan 2 17:27:59 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 08:27:59 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] Message-ID: <5c2ce68fc7728_49812adc5489e58054583@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/jaltman/win32-noreturn Home: https://github.com/heimdal/heimdal **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Wed Jan 2 19:56:07 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 10:56:07 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] a6e691: Fix warning in sl compiler output Message-ID: <5c2d09476d97a_1eeb2aeda52a659489116@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: a6e6916c1cd0c472d74c7ed27283b3ed0b9aa1ea https://github.com/heimdal/heimdal/commit/a6e6916c1cd0c472d74c7ed27283b3ed0b9aa1ea Author: Nicolas Williams Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/sl/slc-gram.y Log Message: ----------- Fix warning in sl compiler output Use a cast through uintptr_t to un-const rather than a cast through unsigned long. This was caught by the Appeyor Windows build. Commit: 454e729e84108ac7716167688ee9418d49691b4b https://github.com/heimdal/heimdal/commit/454e729e84108ac7716167688ee9418d49691b4b Author: Nicolas Williams Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/kadm5/admin.h Log Message: ----------- Make KADM5_* flags unsigned, fix warning Commit: 43a911eedca24b9beb2b00c01c63a06253ed793c https://github.com/heimdal/heimdal/commit/43a911eedca24b9beb2b00c01c63a06253ed793c Author: Nicolas Williams Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M kadmin/check.c Log Message: ----------- Fix bug in kadmin check warning message Commit: 299fbf5dac6361bebd296bf0376ee4079aba0384 https://github.com/heimdal/heimdal/commit/299fbf5dac6361bebd296bf0376ee4079aba0384 Author: Nicolas Williams Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/roken/test-getuserinfo.c Log Message: ----------- Fix warning in roken test on Windows Commit: 7c449afbf8e42efd4fc164011371c7d64cb9a351 https://github.com/heimdal/heimdal/commit/7c449afbf8e42efd4fc164011371c7d64cb9a351 Author: Nicolas Williams Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/roken/strpftime-test.h Log Message: ----------- Fix lib/roken test macro redefinition Commit: ffc4ac1d8d699bd332abfb0260c3f8d37b1662c2 https://github.com/heimdal/heimdal/commit/ffc4ac1d8d699bd332abfb0260c3f8d37b1662c2 Author: Nicolas Williams Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/asn1/check-template.c Log Message: ----------- Fix warnings in ASN.1 template test Commit: 752c3a61390e61f3649fa552423c1a4e5c566b59 https://github.com/heimdal/heimdal/commit/752c3a61390e61f3649fa552423c1a4e5c566b59 Author: Nicolas Williams Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/hcrypto/test_dh.c Log Message: ----------- Fix warning in lib/hcrypto/test_dh.c Commit: 7d5f955b519c2852f40060f1f986e27472c7e928 https://github.com/heimdal/heimdal/commit/7d5f955b519c2852f40060f1f986e27472c7e928 Author: Nicolas Williams Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/krb5/test_acl.c Log Message: ----------- Fix warning in lib/krb5/test_acl.c Commit: 6f7c0e53c8166303862e4d6bc20e5869ee1a1c3c https://github.com/heimdal/heimdal/commit/6f7c0e53c8166303862e4d6bc20e5869ee1a1c3c Author: Nicolas Williams Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/gssapi/test_acquire_cred.c Log Message: ----------- Fix warning in lib/gssapi/test_acquire_cred.c Commit: 7b76d6719fa19482f66b89a8070def52dd02a775 https://github.com/heimdal/heimdal/commit/7b76d6719fa19482f66b89a8070def52dd02a775 Author: Nicolas Williams Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/gssapi/mech/gss_krb5.c Log Message: ----------- Fix VC warning about enctypes Compare: https://github.com/heimdal/heimdal/compare/1dd38cc3de95...7b76d6719fa1 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Wed Jan 2 22:28:02 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 13:28:02 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 8867cf: kadmin: kadmin_dispatch out of memory handling Message-ID: <5c2d2ce25bcc3_76a82aed562d05784605c@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/jaltman/kadmin_enomem Home: https://github.com/heimdal/heimdal Commit: 8867cf6b4253d8418aafe7691a4984b8ec476e8d https://github.com/heimdal/heimdal/commit/8867cf6b4253d8418aafe7691a4984b8ec476e8d Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M kadmin/server.c Log Message: ----------- kadmin: kadmin_dispatch out of memory handling Coverity determined that a NULL pointer segmentation fault could occur if krb5_storage_emem() fails. Use krb5_enomem() to set an error message on the context and do not perform further krb5_storage operations. Change-Id: I9587208e46c184bb061443a44581a32dd722de33 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Wed Jan 2 22:59:26 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 13:59:26 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 3fc90e: kadmin: kadmin_dispatch free krb5_principals at fu... Message-ID: <5c2d343ebd7a0_65922afffa47859063548@hookshot-fe-31feec6.cp1-iad.github.net.mail> Branch: refs/heads/jaltman/win32-noreturn Home: https://github.com/heimdal/heimdal Commit: 3fc90e49704f657bce34f5bee79ca420b3f283f4 https://github.com/heimdal/heimdal/commit/3fc90e49704f657bce34f5bee79ca420b3f283f4 Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M kadmin/server.c Log Message: ----------- kadmin: kadmin_dispatch free krb5_principals at function exit Change-Id: Ic50a17abf10c7055574de2236cdf1d1469375d8b **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Wed Jan 2 23:00:37 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 14:00:37 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 3fc90e: kadmin: kadmin_dispatch free krb5_principals at fu... Message-ID: <5c2d3485dd021_2cd12ab5f825e58011619a@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/jaltman/kadmin_enomem Home: https://github.com/heimdal/heimdal Commit: 3fc90e49704f657bce34f5bee79ca420b3f283f4 https://github.com/heimdal/heimdal/commit/3fc90e49704f657bce34f5bee79ca420b3f283f4 Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M kadmin/server.c Log Message: ----------- kadmin: kadmin_dispatch free krb5_principals at function exit Change-Id: Ic50a17abf10c7055574de2236cdf1d1469375d8b **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Wed Jan 2 23:52:42 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 14:52:42 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] ffabfc: kadmin: kadmin_dispatch free krb5_principals at fu... Message-ID: <5c2d40bae6faa_19ca2adc77102588115174@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/jaltman/kadmin_enomem Home: https://github.com/heimdal/heimdal Commit: ffabfc0affc0557d97a026dde52dcb03680b7b48 https://github.com/heimdal/heimdal/commit/ffabfc0affc0557d97a026dde52dcb03680b7b48 Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M kadmin/server.c Log Message: ----------- kadmin: kadmin_dispatch free krb5_principals at function exit Change-Id: Ic50a17abf10c7055574de2236cdf1d1469375d8b **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Thu Jan 3 00:29:10 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 15:29:10 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] d8394c: Add new kadmin/ktutil --keep* and --enctypes opts Message-ID: <5c2d4946ea991_5eae2ac0b2e3657865915@hookshot-fe-31feec6.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: d8394c65b763e944e410046fe75f3c548a3e2f18 https://github.com/heimdal/heimdal/commit/d8394c65b763e944e410046fe75f3c548a3e2f18 Author: Nicolas Williams Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M admin/change.c M admin/get.c M admin/ktutil-commands.in M admin/ktutil.1 M kadmin/ank.c M kadmin/cpw.c M kadmin/ext.c M kadmin/get.c M kadmin/kadmin-commands.in M kadmin/kadmin.1 M kadmin/kadmind.8 M kadmin/server.c M lib/kadm5/randkey_s.c M lib/kadm5/version-script-client.map M lib/krb5/libkrb5-exports.def.in M lib/krb5/salt.c M lib/krb5/version-script.map M tests/kdc/check-kadmin.in Log Message: ----------- Add new kadmin/ktutil --keep* and --enctypes opts - Add --keepold/keepallold/pruneall options to various kadmin/ktutil commands. Default behavior to "prune old keys". - When setting keys for a service, we need to specify enctypes for it: - Always use kadm5_randkey_principal_3() instead of the older kadm5_randkey_principal(). - Add krb5_string_to_keysalts2(), like MIT's krb5_string_to_keysalts(), but with a context, and simpler. - Add --enctypes options to various kadmin/ktutil commands. - Add [libdefaults] supported_enctypes param with enctype[:salttype] list. - Add [realms] realm supported_enctypes param with enctype[:salttype] list. Default to aes128-cts-hmac-sha1-96:normal. Commit: ff7a969c321a99364fcd9c437b5654eb261b1fdd https://github.com/heimdal/heimdal/commit/ff7a969c321a99364fcd9c437b5654eb261b1fdd Author: Nicolas Williams Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M kadmin/kadmind.8 Log Message: ----------- Begin documenting [password_quality] configuration Compare: https://github.com/heimdal/heimdal/compare/7b76d6719fa1...ff7a969c321a **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Thu Jan 3 00:37:48 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 15:37:48 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 453259: kadmin: kadmin_dispatch out of memory handling Message-ID: <5c2d4b4c34c30_a4d2ab728a085701282c0@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/jaltman/kadmin_enomem Home: https://github.com/heimdal/heimdal Commit: 4532594d72d31ff358543cf75d49e77eacfd39b7 https://github.com/heimdal/heimdal/commit/4532594d72d31ff358543cf75d49e77eacfd39b7 Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M kadmin/server.c Log Message: ----------- kadmin: kadmin_dispatch out of memory handling Coverity determined that a NULL pointer segmentation fault could occur if krb5_storage_emem() fails. Use krb5_enomem() to set an error message on the context and do not perform further krb5_storage operations. Change-Id: I9587208e46c184bb061443a44581a32dd722de33 Commit: 4bf9ae132065f0de9b96343dfb48c8c43f188d47 https://github.com/heimdal/heimdal/commit/4bf9ae132065f0de9b96343dfb48c8c43f188d47 Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M kadmin/server.c Log Message: ----------- kadmin: kadmin_dispatch free krb5_principals at function exit Change-Id: Ic50a17abf10c7055574de2236cdf1d1469375d8b Compare: https://github.com/heimdal/heimdal/compare/ffabfc0affc0...4bf9ae132065 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Thu Jan 3 03:19:25 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 18:19:25 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 092cd5: kadmin: kadmin_dispatch out of memory handling Message-ID: <5c2d712ddebed_3cbf2af22e4ae584637a3@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 092cd5e838d686e213d3fb5f97ead03f94ffa232 https://github.com/heimdal/heimdal/commit/092cd5e838d686e213d3fb5f97ead03f94ffa232 Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M kadmin/server.c Log Message: ----------- kadmin: kadmin_dispatch out of memory handling Coverity determined that a NULL pointer segmentation fault could occur if krb5_storage_emem() fails. Use krb5_enomem() to set an error message on the context and do not perform further krb5_storage operations. Change-Id: I9587208e46c184bb061443a44581a32dd722de33 Commit: e787bd1bc15b6a85971a177f0f8f3b9738404e07 https://github.com/heimdal/heimdal/commit/e787bd1bc15b6a85971a177f0f8f3b9738404e07 Author: Jeffrey Altman Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M kadmin/server.c Log Message: ----------- kadmin: kadmin_dispatch free krb5_principals at function exit Change-Id: Ic50a17abf10c7055574de2236cdf1d1469375d8b Compare: https://github.com/heimdal/heimdal/compare/ff7a969c321a...e787bd1bc15b **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Thu Jan 3 03:23:21 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 18:23:21 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 57df2f: gssapi: ntlm mech should use _gss_ntlm_copy_cred()... Message-ID: <5c2d7219f243e_1db72b096a9ec5848032b@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 57df2ff1cc6c66c91d22e92d94435a714db9267c https://github.com/heimdal/heimdal/commit/57df2ff1cc6c66c91d22e92d94435a714db9267c Author: Luke Howard Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/gssapi/ntlm/duplicate_cred.c M lib/gssapi/ntlm/init_sec_context.c Log Message: ----------- gssapi: ntlm mech should use _gss_ntlm_copy_cred() to dup cred **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Thu Jan 3 05:44:55 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 20:44:55 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 1aedba: Travis: cat failure logs, show core backtraces (fi... Message-ID: <5c2d93471511c_6cec2acfb875a57859724@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 1aedba7d6faeca2dc333625e140e41545ceeb4b7 https://github.com/heimdal/heimdal/commit/1aedba7d6faeca2dc333625e140e41545ceeb4b7 Author: Nicolas Williams Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M .travis.yml Log Message: ----------- Travis: cat failure logs, show core backtraces (fix #499) **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Thu Jan 3 06:27:33 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 21:27:33 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] f17e48: gssapi: gss_compare_name() both ways (#503) Message-ID: <5c2d9d455662e_630c2af796028588879bb@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: f17e48f613237667d0737274562e0963e797e77e https://github.com/heimdal/heimdal/commit/f17e48f613237667d0737274562e0963e797e77e Author: Luke Howard Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M lib/gssapi/mech/gss_compare_name.c Log Message: ----------- gssapi: gss_compare_name() both ways (#503) In the case that one name has no MNs and the second name only has an MN, then the order in which the two names are passed in matters, but it shouldn't. Run the comparison both ways. **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Thu Jan 3 08:08:23 2019 From: noreply at github.com (GitHub) Date: Wed, 02 Jan 2019 23:08:23 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 29fe69: gssapi: fix dlsym() return value casting Message-ID: <5c2db4e7bc0b8_5cf02ae5dfe38588552fe@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 29fe69f95f53a067bae76c265945e5a3afcdd3ef https://github.com/heimdal/heimdal/commit/29fe69f95f53a067bae76c265945e5a3afcdd3ef Author: Luke Howard Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M lib/gssapi/gssapi_mech.h M lib/gssapi/mech/gss_mech_switch.c Log Message: ----------- gssapi: fix dlsym() return value casting Fix warnings on Windows (and possibly other platforms) but appropriately casting the return value of dlsym(). Commit: ad426d038576d05a6d1f4420978862802f79dbfd https://github.com/heimdal/heimdal/commit/ad426d038576d05a6d1f4420978862802f79dbfd Author: Luke Howard Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M lib/gssapi/mech/gss_compare_name.c M lib/gssapi/mech/gss_cred.c M lib/gssapi/mech/gss_destroy_cred.c M lib/gssapi/mech/gss_export_sec_context.c M lib/gssapi/mech/gss_import_name.c M lib/gssapi/mech/gss_indicate_mechs.c M lib/gssapi/mech/gss_inquire_context.c M lib/gssapi/mech/gss_inquire_cred.c M lib/gssapi/mech/gss_inquire_cred_by_mech.c M lib/gssapi/mech/gss_inquire_cred_by_oid.c M lib/gssapi/mech/gss_krb5.c M lib/gssapi/mech/gss_unwrap.c M lib/gssapi/mech/gss_utils.c Log Message: ----------- gssapi: import bugfixes from Apple Heimdal-520 * check `ctx->gc_ctx` in `gss_inquire_context()` * check `gm_inquire_cred != NULL` in `gss_inquire_context()` * check `min_lifetime` in `gss_inquire_cred()` * check `gm_inquire_cred_by_mech != NULL` in `gss_inquire_cred_by_mech()` * set mech error in `gss_inquire_cred_by_oid()` * don't clobber error in `gss_inquire_cred_by_oid()` * don't pass NULL minor_status to `gss_krb5_free_lucid_sec_context()` * allow NULL ccache in `gss_krb5_ccache_name()` * NULL names OK in `_gss_find_mn()` * allow empty names in `gss_import_name()` (removes `input_name_buffer` length check). to support ANONYMOUS. in `gss_import_name()`, ignore mech name import failure as long as it's possible to import the name in some other mechanism * better argument validation in `gss_export_sec_context()` * in `gss_compare_name()`, check `mn2 != NULL` * check `gss_add_oid_set_member()` return code in `gss_indicate_mechs()` * in `gss_destroy_cred()`, set output cred handle to `GSS_C_NO_CREDENTIAL` * cast size_t to OM_uint32 where required Commit: 728650f3ddb6c922c6d079485781aabab6fdefa6 https://github.com/heimdal/heimdal/commit/728650f3ddb6c922c6d079485781aabab6fdefa6 Author: Luke Howard Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M lib/gssapi/gssapi_mech.h M lib/gssapi/mech/gss_accept_sec_context.c M lib/gssapi/mech/gss_mech_switch.c Log Message: ----------- gssapi: canonicalize mech OID in gss_accept_sec_context() Commit: 2242b5bc5b3ac4e5c7b7f324e069ab638814f4a8 https://github.com/heimdal/heimdal/commit/2242b5bc5b3ac4e5c7b7f324e069ab638814f4a8 Author: Luke Howard Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M lib/gssapi/krb5/set_cred_option.c M lib/gssapi/mech/gss_krb5.c Log Message: ----------- gssapi: gss_krb5_set_allowable_enctypes prototype mismatch gss_krb5_set_allowable_enctypes() was declared with an array of int32_t types representing the enctype list, but the definition had an array of krb5_enctype. Whilst these are likely the same size, they may not be. On the receiving end, allocate an array of krb5_enctype. Compare: https://github.com/heimdal/heimdal/compare/f17e48f61323...2242b5bc5b3a **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Thu Jan 3 13:26:05 2019 From: noreply at github.com (GitHub) Date: Thu, 03 Jan 2019 04:26:05 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] a7d42c: gssapi: honor initiator credential in SPNEGO (#506... Message-ID: <5c2dff5d72750_2b502ad69d9425701027a8@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: a7d42cdf6b057d21e40b87c6d526574c4d297807 https://github.com/heimdal/heimdal/commit/a7d42cdf6b057d21e40b87c6d526574c4d297807 Author: Luke Howard Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M lib/gssapi/spnego/accept_sec_context.c M lib/gssapi/spnego/compat.c M lib/gssapi/spnego/init_sec_context.c Log Message: ----------- gssapi: honor initiator credential in SPNEGO (#506) SPNEGO uses the callback function initiator_approved() in order to determine mechanism availability. Prior to this commit, is not passed in the initiator credential, so it always uses a default credential. This breaks SPNEGO if a non-default credential (such as one acquired with gss_acquire_cred_with_password()) is used. This commit addresses this. **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Thu Jan 3 21:38:41 2019 From: noreply at github.com (GitHub) Date: Thu, 03 Jan 2019 12:38:41 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] e0bb9c: gssapi: credential store extensions (#451) Message-ID: <5c2e72d1b7f5_748c2afb246f8584956a@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: e0bb9c10cad0fd98245caecf8af8fca855b2df49 https://github.com/heimdal/heimdal/commit/e0bb9c10cad0fd98245caecf8af8fca855b2df49 Author: Luke Howard Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M lib/gssapi/Makefile.am M lib/gssapi/NTMakefile M lib/gssapi/gssapi/gssapi.h M lib/gssapi/gssapi/gssapi_oid.h M lib/gssapi/gssapi_mech.h M lib/gssapi/krb5/acquire_cred.c M lib/gssapi/krb5/add_cred.c M lib/gssapi/krb5/duplicate_cred.c M lib/gssapi/krb5/external.c M lib/gssapi/krb5/gkrb5_err.et M lib/gssapi/krb5/inquire_cred.c M lib/gssapi/krb5/store_cred.c M lib/gssapi/libgssapi-exports.def M lib/gssapi/mech/cred.h M lib/gssapi/mech/gss_acquire_cred.c R lib/gssapi/mech/gss_acquire_cred_ext.c A lib/gssapi/mech/gss_acquire_cred_from.c M lib/gssapi/mech/gss_acquire_cred_with_password.c M lib/gssapi/mech/gss_add_cred.c A lib/gssapi/mech/gss_add_cred_from.c M lib/gssapi/mech/gss_add_cred_with_password.c M lib/gssapi/mech/gss_cred.c M lib/gssapi/mech/gss_duplicate_cred.c M lib/gssapi/mech/gss_mech_switch.c M lib/gssapi/mech/gss_oid.c M lib/gssapi/mech/gss_store_cred.c A lib/gssapi/mech/gss_store_cred_into.c M lib/gssapi/netlogon/external.c M lib/gssapi/ntlm/acquire_cred.c M lib/gssapi/ntlm/duplicate_cred.c M lib/gssapi/ntlm/external.c M lib/gssapi/oid.txt M lib/gssapi/spnego/cred_stubs.c M lib/gssapi/spnego/external.c M lib/gssapi/test_acquire_cred.c M lib/gssapi/test_add_store_cred.c M lib/gssapi/test_context.c M lib/gssapi/version-script.map M tests/gss/check-spnego.in Log Message: ----------- gssapi: credential store extensions (#451) Implement the GSS-API credential store API extensions defined by MIT here: https://k5wiki.kerberos.org/wiki/Projects/Credential_Store_extensions Note: we kill off gss_acquire_cred_ext() here. This was never a public API, although mechanisms could have implemented it and I briefly used it in my BrowserID prototype mechanism. gss_acquire_cred_ext_from() occupies the place in the dispatch table where gss_acquire_cred_ext() used to, but this structure was never visible outside Heimdal (i.e. it is only used by internal mechanisms); (Mechanisms that need to accept arbitrary key/value dictionaries from applications should now implement gss_acquire_cred_from().) Commit: 83f15553e0d12d0f849cfc2581a7d9acf0982e21 https://github.com/heimdal/heimdal/commit/83f15553e0d12d0f849cfc2581a7d9acf0982e21 Author: Luke Howard Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M lib/gssapi/Makefile.am M lib/gssapi/NTMakefile A lib/gssapi/mech/cred.c M lib/gssapi/mech/cred.h M lib/gssapi/mech/gss_accept_sec_context.c M lib/gssapi/mech/gss_acquire_cred_from.c M lib/gssapi/mech/gss_add_cred_from.c M lib/gssapi/mech/gss_canonicalize_name.c M lib/gssapi/mech/gss_cred.c M lib/gssapi/mech/gss_delete_sec_context.c M lib/gssapi/mech/gss_duplicate_cred.c M lib/gssapi/mech/gss_duplicate_name.c M lib/gssapi/mech/gss_import_name.c M lib/gssapi/mech/gss_init_sec_context.c M lib/gssapi/mech/gss_inquire_context.c M lib/gssapi/mech/gss_inquire_cred.c M lib/gssapi/mech/gss_inquire_cred_by_mech.c M lib/gssapi/mech/gss_names.c M lib/gssapi/mech/gss_release_cred.c M lib/gssapi/mech/gss_release_name.c M lib/gssapi/mech/gss_set_cred_option.c M lib/gssapi/mech/name.h Log Message: ----------- gssapi: import mechglue allocation utility functions from Heimdal-520 Apple's Heimdal impelmentation uses a number of utility functions for allocating names and credentials, to avoid calling malloc or calloc directly. Import them. Commit: e9b3b2326d93efbfe83c4f6175fc5ade5e18a750 https://github.com/heimdal/heimdal/commit/e9b3b2326d93efbfe83c4f6175fc5ade5e18a750 Author: Luke Howard Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M lib/gssapi/mech/context.c M lib/gssapi/mech/context.h M lib/gssapi/mech/gss_accept_sec_context.c M lib/gssapi/mech/gss_acquire_cred_from.c M lib/gssapi/mech/gss_add_cred_from.c M lib/gssapi/mech/gss_canonicalize_name.c M lib/gssapi/mech/gss_delete_name_attribute.c M lib/gssapi/mech/gss_display_name_ext.c M lib/gssapi/mech/gss_display_status.c M lib/gssapi/mech/gss_duplicate_cred.c M lib/gssapi/mech/gss_export_name_composite.c M lib/gssapi/mech/gss_export_sec_context.c M lib/gssapi/mech/gss_get_name_attribute.c M lib/gssapi/mech/gss_import_name.c M lib/gssapi/mech/gss_import_sec_context.c M lib/gssapi/mech/gss_init_sec_context.c M lib/gssapi/mech/gss_inquire_context.c M lib/gssapi/mech/gss_inquire_cred_by_mech.c M lib/gssapi/mech/gss_inquire_cred_by_oid.c M lib/gssapi/mech/gss_inquire_name.c M lib/gssapi/mech/gss_inquire_sec_context_by_oid.c M lib/gssapi/mech/gss_names.c M lib/gssapi/mech/gss_pname_to_uid.c M lib/gssapi/mech/gss_pseudo_random.c M lib/gssapi/mech/gss_set_cred_option.c M lib/gssapi/mech/gss_set_name_attribute.c M lib/gssapi/mech/gss_set_sec_context_option.c Log Message: ----------- gssapi: remove non-mech status from _gss_mg_error() from Heimdal-520 _gss_mg_error() should only handle mechanism-specific status codes which are returned in minor_status. major_status has a global namespace. Compare: https://github.com/heimdal/heimdal/compare/a7d42cdf6b05...e9b3b2326d93 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Fri Jan 4 03:06:29 2019 From: noreply at github.com (GitHub) Date: Thu, 03 Jan 2019 18:06:29 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 803efe: krb5, kadm5: refactor plugin API Message-ID: <5c2ebfa56da1a_2e262b11f4aba5789833f@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 803efebca575d3d4e0fae2dc7eda279d392c3d8c https://github.com/heimdal/heimdal/commit/803efebca575d3d4e0fae2dc7eda279d392c3d8c Author: Luke Howard Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M kdc/windc.c M lib/hdb/hdb.c M lib/hdb/keys.c M lib/hdb/libhdb-exports.def M lib/hdb/version-script.map M lib/kadm5/Makefile.am M lib/kadm5/NTMakefile M lib/kadm5/chpass_s.c M lib/kadm5/create_s.c M lib/kadm5/delete_s.c M lib/kadm5/kadm5-hook.h M lib/kadm5/kadm5_locl.h M lib/kadm5/libkadm5srv-exports.def M lib/kadm5/modify_s.c M lib/kadm5/private.h M lib/kadm5/prune_s.c M lib/kadm5/randkey_s.c M lib/kadm5/rename_s.c M lib/kadm5/sample_hook.c M lib/kadm5/server_hooks.c M lib/kadm5/setkey3_s.c M lib/kadm5/test_pw_quality.c M lib/kadm5/version-script.map M lib/krb5/aname_to_localname.c M lib/krb5/context.c M lib/krb5/db_plugin.c M lib/krb5/krb5-plugin.7 M lib/krb5/krb5.h M lib/krb5/krb5_locl.h M lib/krb5/krbhst.c M lib/krb5/kuserok.c M lib/krb5/libkrb5-exports.def.in M lib/krb5/pcache.c M lib/krb5/plugin.c M lib/krb5/send_to_kdc.c M lib/krb5/test_plugin.c M lib/krb5/version-script.map Log Message: ----------- krb5, kadm5: refactor plugin API Refactor plugin framework to use a single list of loaded plugins; add a new plugin API where DSOs export a load function that can declare dependencies and export multiple plugins; refactor kadm5 hook API to use krb5 plugin framework. More information in krb5-plugin(7). Commit: befe1b8f906929654afdc83d9d47f8d60e92370e https://github.com/heimdal/heimdal/commit/befe1b8f906929654afdc83d9d47f8d60e92370e Author: Luke Howard Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M lib/gssapi/mech/gss_mech_switch.c M lib/hcrypto/engine.c M lib/hcrypto/evp-pkcs11.c M lib/hx509/ks_p11.c M lib/kadm5/password_quality.c M lib/krb5/acache.c M lib/krb5/plugin.c M lib/roken/roken-common.h M lib/roken/roken.h.in Log Message: ----------- always load plugins with RTLD_LOCAL/RTLD_GROUP if available Compare: https://github.com/heimdal/heimdal/compare/e9b3b2326d93...befe1b8f9069 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Fri Jan 4 05:19:27 2019 From: noreply at github.com (GitHub) Date: Thu, 03 Jan 2019 20:19:27 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] e739c4: windc: update test windc plugin to use new load SP... Message-ID: <5c2edecf8179_1fd92ad68628c5941166ce@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: e739c4d0c21a931c426d9b6dae789c6ec7137d09 https://github.com/heimdal/heimdal/commit/e739c4d0c21a931c426d9b6dae789c6ec7137d09 Author: Luke Howard Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M tests/plugin/windc.c Log Message: ----------- windc: update test windc plugin to use new load SPI **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Fri Jan 4 05:26:39 2019 From: noreply at github.com (GitHub) Date: Thu, 03 Jan 2019 20:26:39 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] d5536d: Fix wrong context bugs in kadmin randkey Message-ID: <5c2ee07f2fa94_7aa62ac2784165941212b9@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: d5536d4dd340b5c6cb99583bb328fffa4693dbdf https://github.com/heimdal/heimdal/commit/d5536d4dd340b5c6cb99583bb328fffa4693dbdf Author: Nicolas Williams Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M kadmin/server.c M lib/kadm5/randkey_s.c Log Message: ----------- Fix wrong context bugs in kadmin randkey **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Fri Jan 4 05:49:59 2019 From: noreply at github.com (GitHub) Date: Thu, 03 Jan 2019 20:49:59 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] dfaaf9: gssapi: honor acceptor credential in SPNEGO (#506) Message-ID: <5c2ee5f78cf2f_72b02b0d8a3885841341ee@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: dfaaf9c93fe02ddb216a4dd3764fdcd41e063025 https://github.com/heimdal/heimdal/commit/dfaaf9c93fe02ddb216a4dd3764fdcd41e063025 Author: Luke Howard Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M lib/gssapi/spnego/accept_sec_context.c Log Message: ----------- gssapi: honor acceptor credential in SPNEGO (#506) SPNEGO uses the callback function acceptor_approved() in order to determine which mechanisms to advertise to the initiator in the case that the initiator sent an empty initial context token. Prior to this commit, that function was not passed in the acceptor credential (if present), so always uses a default credential. For correctness, we should only advertise the availability of mechanisms for which we have a credential. **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Fri Jan 4 05:50:13 2019 From: noreply at github.com (GitHub) Date: Thu, 03 Jan 2019 20:50:13 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 735039: gssapi: implement gss_set_neg_mechs() (#495) Message-ID: <5c2ee6058f135_5bb92ae032ae2580520c3@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 735039dbdc3aa58d06afdefd214efe3f5e421244 https://github.com/heimdal/heimdal/commit/735039dbdc3aa58d06afdefd214efe3f5e421244 Author: Luke Howard Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M lib/gssapi/Makefile.am M lib/gssapi/NTMakefile M lib/gssapi/gssapi/gssapi.h M lib/gssapi/gssapi_mech.h M lib/gssapi/krb5/external.c M lib/gssapi/libgssapi-exports.def M lib/gssapi/mech/cred.c A lib/gssapi/mech/gss_get_neg_mechs.c M lib/gssapi/mech/gss_mech_switch.c A lib/gssapi/mech/gss_set_neg_mechs.c M lib/gssapi/netlogon/external.c M lib/gssapi/ntlm/external.c M lib/gssapi/spnego/cred_stubs.c M lib/gssapi/spnego/external.c M lib/gssapi/version-script.map Log Message: ----------- gssapi: implement gss_set_neg_mechs() (#495) Implementation of gss_set_neg_mechs() and gss_get_neg_mechs() as defined in RFC 4178. New gss_release_cred_by_mech() API for dropping a credential from a mechanism glue credential. **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Fri Jan 4 07:03:46 2019 From: noreply at github.com (GitHub) Date: Thu, 03 Jan 2019 22:03:46 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 00c590: fix null pointer dereference errors Message-ID: <5c2ef74281602_657f2ad1400205801295ac@hookshot-fe-31feec6.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 00c590e4ff50a85560674ee8898493be9fc06563 https://github.com/heimdal/heimdal/commit/00c590e4ff50a85560674ee8898493be9fc06563 Author: Jeffrey Altman Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M kadmin/rpc.c M lib/gssapi/mech/gss_export_sec_context.c M lib/kadm5/log.c M lib/kadm5/marshall.c M lib/krb5/fcache.c Log Message: ----------- fix null pointer dereference errors Change-Id: I82a849afe9f432a1084ad2505ce88b1fe4d3d3af **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Fri Jan 4 07:22:48 2019 From: noreply at github.com (GitHub) Date: Thu, 03 Jan 2019 22:22:48 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 911913: fix memory leaks Message-ID: <5c2efbb864faf_5e22ac0a487c57880437@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 9119136967242aa36ba2dc3f91e3e4a627840fd2 https://github.com/heimdal/heimdal/commit/9119136967242aa36ba2dc3f91e3e4a627840fd2 Author: Jeffrey Altman Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M admin/change.c M kadmin/ank.c Log Message: ----------- fix memory leaks Change-Id: I18ad15dc802842324b3712f3f7833953434b1cf1 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Fri Jan 4 07:31:41 2019 From: noreply at github.com (GitHub) Date: Thu, 03 Jan 2019 22:31:41 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] e23b0a: gssapi: argument validation fixes gss_store_cred_i... Message-ID: <5c2efdcd26f57_48642b0ef03365888039b@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: e23b0a39d3f70d91a24e0ff269f0b5c5e980adf3 https://github.com/heimdal/heimdal/commit/e23b0a39d3f70d91a24e0ff269f0b5c5e980adf3 Author: Luke Howard Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M lib/gssapi/mech/gss_store_cred_into.c Log Message: ----------- gssapi: argument validation fixes gss_store_cred_into() **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Fri Jan 4 07:41:36 2019 From: noreply at github.com (GitHub) Date: Thu, 03 Jan 2019 22:41:36 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 750cfc: fix 00c590e4ff50a85560674ee8898493be9fc06563 Message-ID: <5c2f0020e6d36_1efb2abd52c5c580147746@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 750cfc092c3b8f3bea4d9546bfd07622e48662a3 https://github.com/heimdal/heimdal/commit/750cfc092c3b8f3bea4d9546bfd07622e48662a3 Author: Jeffrey Altman Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M kadmin/rpc.c Log Message: ----------- fix 00c590e4ff50a85560674ee8898493be9fc06563 Change-Id: I73623d71842086374ae58c6e751395fd6925a704 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Fri Jan 4 07:48:19 2019 From: noreply at github.com (GitHub) Date: Thu, 03 Jan 2019 22:48:19 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] b025f2: kadmin: kadmind_dispatch incompatible pointer warn... Message-ID: <5c2f01b319b5a_62932ab683670584114356@hookshot-fe-31feec6.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: b025f20eb4ee11b82b1a8e779bee1fb20477e7fa https://github.com/heimdal/heimdal/commit/b025f20eb4ee11b82b1a8e779bee1fb20477e7fa Author: Jeffrey Altman Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M kadmin/server.c Log Message: ----------- kadmin: kadmind_dispatch incompatible pointer warning warning: incompatible pointer types passing 'int *' to parameter of type 'size_t *' (aka 'unsigned long *') [-Wincompatible-pointer-types] Change-Id: Id75b1b1c9b46b63ab61134f4f91b7c2909d87077 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Fri Jan 4 08:09:06 2019 From: noreply at github.com (GitHub) Date: Thu, 03 Jan 2019 23:09:06 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 178588: gssapi: refactor gss_duplicate_cred() Message-ID: <5c2f0692a7ff_4d462adb22990584895b7@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 178588516d68fefdc3b2ea06e82c195171ddd263 https://github.com/heimdal/heimdal/commit/178588516d68fefdc3b2ea06e82c195171ddd263 Author: Luke Howard Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M lib/gssapi/mech/gss_duplicate_cred.c Log Message: ----------- gssapi: refactor gss_duplicate_cred() Refactor gss_duplicate_cred() to consolidate branches in copy_cred_element() and eliminate use of GSS_S_UNAVAILABLE sentinel **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Fri Jan 4 08:12:37 2019 From: noreply at github.com (GitHub) Date: Thu, 03 Jan 2019 23:12:37 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 7fc79a: gssapi: defensively initialize *out in gss_duplica... Message-ID: <5c2f07657b44_5e3a2ada6faaa57c463e5@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 7fc79a393cc983b1f2b6ed2628fe5640758b40e9 https://github.com/heimdal/heimdal/commit/7fc79a393cc983b1f2b6ed2628fe5640758b40e9 Author: Luke Howard Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M lib/gssapi/mech/gss_duplicate_cred.c Log Message: ----------- gssapi: defensively initialize *out in gss_duplicate_cred() **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Fri Jan 4 08:23:44 2019 From: noreply at github.com (GitHub) Date: Thu, 03 Jan 2019 23:23:44 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 9a6436: Fix Travis core analysis; do not cat config.log Message-ID: <5c2f0a00478f6_6c192aba764e05741242b5@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 9a6436fe3c67ac364e01ebc54917fc79393ff2e0 https://github.com/heimdal/heimdal/commit/9a6436fe3c67ac364e01ebc54917fc79393ff2e0 Author: Nicolas Williams Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M .travis.yml Log Message: ----------- Fix Travis core analysis; do not cat config.log **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Fri Jan 4 08:27:43 2019 From: noreply at github.com (GitHub) Date: Thu, 03 Jan 2019 23:27:43 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 99e985: Travis: only one core analysis command Message-ID: <5c2f0aefc0f28_658b2b254d3445701029fd@hookshot-fe-31feec6.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 99e98520ba9b7e7d1c3ded6b457acc7b8177f1c8 https://github.com/heimdal/heimdal/commit/99e98520ba9b7e7d1c3ded6b457acc7b8177f1c8 Author: Nicolas Williams Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M .travis.yml Log Message: ----------- Travis: only one core analysis command **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Fri Jan 4 11:30:28 2019 From: noreply at github.com (GitHub) Date: Fri, 04 Jan 2019 02:30:28 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 7de958: gssapi: add some Apple (c) notices for mechglue bu... Message-ID: <5c2f35c4e0ae5_1ddd2b14e45d05741230e8@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 7de958252c409df2b7cb9891494d18db68ca0202 https://github.com/heimdal/heimdal/commit/7de958252c409df2b7cb9891494d18db68ca0202 Author: Luke Howard Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M lib/gssapi/gssapi_mech.h M lib/gssapi/mech/gss_acquire_cred_from.c M lib/gssapi/mech/gss_canonicalize_name.c M lib/gssapi/mech/gss_compare_name.c M lib/gssapi/mech/gss_init_sec_context.c Log Message: ----------- gssapi: add some Apple (c) notices for mechglue bugfix import ad426d03 imported some minor bugfixes from the Darwin Heimdal-520 drop; a few copyright notices were omitted in the merge, which are included here. **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Fri Jan 4 18:26:35 2019 From: noreply at github.com (GitHub) Date: Fri, 04 Jan 2019 09:26:35 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 9b3997: Fix tests/plugin/windc.c Message-ID: <5c2f974b76197_71f32ab8ce1d057c60419@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 9b39978ddd2add0cce7540b8d755fd633d22ca06 https://github.com/heimdal/heimdal/commit/9b39978ddd2add0cce7540b8d755fd633d22ca06 Author: Nicolas Williams Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M tests/plugin/windc.c Log Message: ----------- Fix tests/plugin/windc.c **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Fri Jan 4 18:30:58 2019 From: noreply at github.com (GitHub) Date: Fri, 04 Jan 2019 09:30:58 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 260486: One more Travis fix Message-ID: <5c2f9852f1224_7d742b16f080857c1060bc@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 26048694d736aa844d2be0abc6bd82a1cf51cfef https://github.com/heimdal/heimdal/commit/26048694d736aa844d2be0abc6bd82a1cf51cfef Author: Nicolas Williams Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M .travis.yml Log Message: ----------- One more Travis fix **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Fri Jan 4 19:50:01 2019 From: noreply at github.com (GitHub) Date: Fri, 04 Jan 2019 10:50:01 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 99188e: Bump roken SONAME version (fix #279) Message-ID: <5c2faad91338_1f192b1faf3f058074231@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 99188ea797d75fc73a32f13d668a4cc0d3db932c https://github.com/heimdal/heimdal/commit/99188ea797d75fc73a32f13d668a4cc0d3db932c Author: Nicolas Williams Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M lib/roken/Makefile.am M lib/roken/version-script.map Log Message: ----------- Bump roken SONAME version (fix #279) **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Sat Jan 5 00:48:29 2019 From: noreply at github.com (GitHub) Date: Fri, 04 Jan 2019 15:48:29 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] e776e6: Revert "Fix tests/plugin/windc.c" Message-ID: <5c2ff0cd84074_7c0c2aebf4690590131093@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: e776e6c5ed927c753b270eef7c3de922aae2b4e5 https://github.com/heimdal/heimdal/commit/e776e6c5ed927c753b270eef7c3de922aae2b4e5 Author: Luke Howard Date: 2019-01-05 (Sat, 05 Jan 2019) Changed paths: M tests/plugin/windc.c Log Message: ----------- Revert "Fix tests/plugin/windc.c" Will fix by exporting kdc_get_instance() from libkdc. Commit: ac544a6da6be77273a579fddd0ae5e6c579ee1e1 https://github.com/heimdal/heimdal/commit/ac544a6da6be77273a579fddd0ae5e6c579ee1e1 Author: Luke Howard Date: 2019-01-05 (Sat, 05 Jan 2019) Changed paths: M kdc/libkdc-exports.def M kdc/version-script.map Log Message: ----------- kdc: export kdc_get_instance() for windc plugins Compare: https://github.com/heimdal/heimdal/compare/99188ea797d7...ac544a6da6be **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Sat Jan 5 00:56:24 2019 From: noreply at github.com (GitHub) Date: Fri, 04 Jan 2019 15:56:24 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 2287c2: Revert "Revert "Fix tests/plugin/windc.c"" Message-ID: <5c2ff2a89febc_36072ac07390a584453d7@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 2287c250b2eaa5d03ecb331adb8032e6567db53a https://github.com/heimdal/heimdal/commit/2287c250b2eaa5d03ecb331adb8032e6567db53a Author: Luke Howard Date: 2019-01-05 (Sat, 05 Jan 2019) Changed paths: M tests/plugin/windc.c Log Message: ----------- Revert "Revert "Fix tests/plugin/windc.c"" windc doesn't link against libkdc, so it doesn't need to check its instance; however, we will continue to export kdc_get_instance() from libkdc in case other windc plugins do link against it. **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Sat Jan 5 04:01:27 2019 From: noreply at github.com (GitHub) Date: Fri, 04 Jan 2019 19:01:27 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] c6d00f: Revert "KDC: Allow hdb to set the issued ticket's ... Message-ID: <5c301e07d71a2_6c752af8a0b6258885192@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: c6d00f250296ee49822025b52e9b75b67a85e194 https://github.com/heimdal/heimdal/commit/c6d00f250296ee49822025b52e9b75b67a85e194 Author: Luke Howard Date: 2019-01-05 (Sat, 05 Jan 2019) Changed paths: M kdc/krb5tgs.c Log Message: ----------- Revert "KDC: Allow hdb to set the issued ticket's realm" This reverts commit c555ed6a1f7ddb1cb391326140a0c30a68a9b700. Commit: 6bb8eaca2052967bbda194e2c2bc0622b18a4d2f https://github.com/heimdal/heimdal/commit/6bb8eaca2052967bbda194e2c2bc0622b18a4d2f Author: Luke Howard Date: 2019-01-05 (Sat, 05 Jan 2019) Changed paths: M kdc/krb5tgs.c M lib/hdb/common.c M lib/hdb/hdb.asn1 Log Message: ----------- hdb: dereference principal aliases in all KDC lookups (#452) e11abf41 added support in libhdb for always dereferencing principal aliases during an AS-REQ (where dereferencing refers to enabling alias lookups, and rewriting the returned entry with the alias name unless canonicalization was enabled). Due to the KDC setting HDB_F_FOR_AS_REQ for all lookups from the AS, this allowed aliases on the TGS itself to be dereferenced during an AS-REQ; however, on presenting the TGT, the TGS would fail to resolve. Creating an explicit TGS principal for the aliased realm would work (at least prior to c555ed6a), but this could be confusing to deploy. This commit changes enables alias dereferencing when HDB_F_GET_ANY is set, which essentially means dereference whenever the request is coming from the KDC (as opposed to, say, kadmin). We also backout c555ed6a, which changed the TGS to always canonicalize the server realm, as this breaks serving multiple realms from a single KDC, where server principals in different realms share a single canonical entry. HDB_F_CANON is now passed to the backend as a hint only, and per RFC 6806 the principal name is never changed in TGS replies. (However, for Samba interop, backends can override this by setting the force-canonicalize HDB flag.) Compare: https://github.com/heimdal/heimdal/compare/2287c250b2ea...6bb8eaca2052 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Sat Jan 5 05:51:13 2019 From: noreply at github.com (GitHub) Date: Fri, 04 Jan 2019 20:51:13 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] c62322: kdc: perform AS-REQ canonicalization in kdc Message-ID: <5c3037c131444_1a932ac22fbf657815519a@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: c6232299c3b2831d5d8ecf701fcd286ae509fba8 https://github.com/heimdal/heimdal/commit/c6232299c3b2831d5d8ecf701fcd286ae509fba8 Author: Luke Howard Date: 2019-01-05 (Sat, 05 Jan 2019) Changed paths: M kdc/kerberos5.c M lib/hdb/common.c Log Message: ----------- kdc: perform AS-REQ canonicalization in kdc Mirroring the logic recently introduced in the TGS, this patch modifies the KDC to perform client and server canonicalization itself rather than relying on the backend to do so. Per RFC 6806, the behavior is slightly different for the AS in that the setting of the canonicalize flag in the AS-REQ does impact the returned names in the ticket. In order to support realm canonicalization or other custom behavior, we allow the backend to force the KDC to canonicalize by setting the force-canonicalize flag in the returned client or server entries. Commit: 1b7e196e6608816d18ed81c6fff0383263877478 https://github.com/heimdal/heimdal/commit/1b7e196e6608816d18ed81c6fff0383263877478 Author: Luke Howard Date: 2019-01-05 (Sat, 05 Jan 2019) Changed paths: M kdc/kerberos5.c M lib/hdb/common.c Log Message: ----------- kdc: move more name canonicalization logic to KDC Enterprise principal client names in AS-REQs should always be canonicalized irrespective of the setting the canonicalize KDC option. Perform this check in the KDC rather than HDB. Do not set the HDB_F_GET_KRBTGT flag unless the client actually requested a TGS principal. Compare: https://github.com/heimdal/heimdal/compare/6bb8eaca2052...1b7e196e6608 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Sat Jan 5 06:33:13 2019 From: noreply at github.com (GitHub) Date: Fri, 04 Jan 2019 21:33:13 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 79f849: hdb: krb5_locl.h obviates need for forward declara... Message-ID: <5c3041993dffa_39a42ad287330570475ac@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 79f84913c9b379d67096355de194a41a750437ca https://github.com/heimdal/heimdal/commit/79f84913c9b379d67096355de194a41a750437ca Author: Luke Howard Date: 2019-01-05 (Sat, 05 Jan 2019) Changed paths: M lib/hdb/keys.c Log Message: ----------- hdb: krb5_locl.h obviates need for forward declarations **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Sun Jan 6 08:04:32 2019 From: noreply at github.com (GitHub) Date: Sat, 05 Jan 2019 23:04:32 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 0141e7: Revert "kdc: move more name canonicalization logic... Message-ID: <5c31a8805e424_59a2abc0421457c1303c7@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 0141e7a497ba9db45c5e2d422d9b8be78cbd1048 https://github.com/heimdal/heimdal/commit/0141e7a497ba9db45c5e2d422d9b8be78cbd1048 Author: Luke Howard Date: 2019-01-06 (Sun, 06 Jan 2019) Changed paths: M kdc/kerberos5.c M lib/hdb/common.c Log Message: ----------- Revert "kdc: move more name canonicalization logic to KDC" This reverts commit 1b7e196e6608816d18ed81c6fff0383263877478. It turns out that, contrary to the referrals draft, Windows does not canonicalize enterprise principal names if the canonicalize KDC option is unset. Commit: 4ea5cc2eff10a0750bfb6ed8424eaee08a528039 https://github.com/heimdal/heimdal/commit/4ea5cc2eff10a0750bfb6ed8424eaee08a528039 Author: Luke Howard Date: 2019-01-06 (Sun, 06 Jan 2019) Changed paths: M kdc/kerberos5.c Log Message: ----------- kdc: only set HDB_F_GET_KRBTGT when requesting TGS principal Commit: 9750f2d9152abb35d36a98795b272285c468dd28 https://github.com/heimdal/heimdal/commit/9750f2d9152abb35d36a98795b272285c468dd28 Author: Luke Howard Date: 2019-01-06 (Sun, 06 Jan 2019) Changed paths: M lib/hdb/common.c Log Message: ----------- hdb: force canonicalization of enterprise principal names Whilst Windows does not canonicalize enterprise principal names if the canonicalize flag is unset, the original specification in draft-ietf-krb-wg-kerberos-referrals-03.txt says we should. Non-Windows deployments of Heimdals are unlikely to understand enterprise principal names in tickets, and are also unlikely to set the canonicalize flag, so this makes sense. (It was also the behavior prior to moving the name canonicalization logic into the KDC.) Compare: https://github.com/heimdal/heimdal/compare/79f84913c9b3...9750f2d9152a **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Mon Jan 7 03:50:26 2019 From: noreply at github.com (GitHub) Date: Sun, 06 Jan 2019 18:50:26 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 83d295: gssapi: SPNEGO does not reset NTLM RC4 state (#509... Message-ID: <5c32be72b2df7_77bf2ad42620e584130629@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 83d2951c0db06c279838f79bf75497652d8abc11 https://github.com/heimdal/heimdal/commit/83d2951c0db06c279838f79bf75497652d8abc11 Author: Luke Howard Date: 2019-01-06 (Sun, 06 Jan 2019) Changed paths: M lib/gssapi/Makefile.am M lib/gssapi/NTMakefile M lib/gssapi/gssapi/gssapi_oid.h M lib/gssapi/mech/gss_oid.c M lib/gssapi/ntlm/accept_sec_context.c M lib/gssapi/ntlm/crypto.c M lib/gssapi/ntlm/external.c A lib/gssapi/ntlm/set_sec_context_option.c M lib/gssapi/oid.txt M lib/gssapi/spnego/accept_sec_context.c M lib/gssapi/spnego/compat.c M lib/gssapi/spnego/init_sec_context.c Log Message: ----------- gssapi: SPNEGO does not reset NTLM RC4 state (#509) **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Mon Jan 7 05:29:24 2019 From: noreply at github.com (GitHub) Date: Sun, 06 Jan 2019 20:29:24 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 31c15c: kdc: get_pa_etype_info_both comply with RFC4120 Message-ID: <5c32d5a4c6604_1a382adb47f985881312d6@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/jaltman/kdc-pa-etype-info-generation Home: https://github.com/heimdal/heimdal Commit: 31c15c0ca6b56735cd6c1f90ca0556239640ea04 https://github.com/heimdal/heimdal/commit/31c15c0ca6b56735cd6c1f90ca0556239640ea04 Author: Jeffrey Altman Date: 2019-01-06 (Sun, 06 Jan 2019) Changed paths: M kdc/kerberos5.c Log Message: ----------- kdc: get_pa_etype_info_both comply with RFC4120 Heimdal's current behavior regarding the generation of PA-ETYPE-INFO2 and PA-ETYPE-INFO violates RFC4120 in two ways: 1. when generating responding both PA-ETYPE-INFO2 and PA-ETYPE-INFO the hints returned in the inverse order: INFO then INFO2 instead of INFO2 then INFO. 2. the determination that both PA-ETYPE-INFO2 and PA-ETYPE-INFO is currently based upon the KDC selected enctype when it should be determine based upon examining the entire enctype list specified by the requesting client. This change corrects the behavior to follow the RFC4120 guidance. Change-Id: I6ebda8a813c25f9296f10314e32e93a22380ca72 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Mon Jan 7 05:43:57 2019 From: noreply at github.com (GitHub) Date: Sun, 06 Jan 2019 20:43:57 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 828dde: kdc: get_pa_etype_info_both comply with RFC4120 Message-ID: <5c32d90d1887a_6c512b109d36e58892944@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 828ddecd6134987a64729b01ec2d9c9e0ae4222e https://github.com/heimdal/heimdal/commit/828ddecd6134987a64729b01ec2d9c9e0ae4222e Author: Jeffrey Altman Date: 2019-01-07 (Mon, 07 Jan 2019) Changed paths: M kdc/kerberos5.c Log Message: ----------- kdc: get_pa_etype_info_both comply with RFC4120 Heimdal's current behavior regarding the generation of PA-ETYPE-INFO2 and PA-ETYPE-INFO violates RFC4120 in two ways: 1. when generating responding both PA-ETYPE-INFO2 and PA-ETYPE-INFO the hints returned in the inverse order: INFO then INFO2 instead of INFO2 then INFO. 2. the determination that both PA-ETYPE-INFO2 and PA-ETYPE-INFO is currently based upon the KDC selected enctype when it should be determine based upon examining the entire enctype list specified by the requesting client. This change corrects the behavior to follow the RFC4120 guidance. Change-Id: I6ebda8a813c25f9296f10314e32e93a22380ca72 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Mon Jan 7 06:33:10 2019 From: noreply at github.com (GitHub) Date: Sun, 06 Jan 2019 21:33:10 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] a3fd75: hdb: generate default salts for entries missing th... Message-ID: <5c32e49656242_586d2b07822da57813396b@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: a3fd75f368c0f22482d87d97b98e66e6fc3ffd21 https://github.com/heimdal/heimdal/commit/a3fd75f368c0f22482d87d97b98e66e6fc3ffd21 Author: Luke Howard Date: 2019-01-07 (Mon, 07 Jan 2019) Changed paths: M lib/hdb/common.c Log Message: ----------- hdb: generate default salts for entries missing them Older databases may lack explicitly stored salts where the salt is the default one. When fetching a client entry for an AS-REQ, add default salts to keys that lack one. Commit: de1f37a6aadb35fdce3254528d89bdac23fb120b https://github.com/heimdal/heimdal/commit/de1f37a6aadb35fdce3254528d89bdac23fb120b Author: Luke Howard Date: 2019-01-07 (Mon, 07 Jan 2019) Changed paths: M kdc/kerberos5.c M kdc/krb5tgs.c Log Message: ----------- kdc: omit default salt from PA-ETYPE-INFO[2] If the salt for the AS-REP client key matches the default password salt for the client principal in the AS-REQ, then it can be omitted from the PA-ETYPE-INFO, PA-ETYPE-INFO2 (RFC4120) as the client will assume the default salt in its absence. Compare: https://github.com/heimdal/heimdal/compare/828ddecd6134...de1f37a6aadb **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Mon Jan 7 06:37:31 2019 From: noreply at github.com (GitHub) Date: Sun, 06 Jan 2019 21:37:31 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] Message-ID: <5c32e59bb3791_49242b29b8a505701403fa@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/jaltman/kdc-pa-etype-info-generation Home: https://github.com/heimdal/heimdal **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Mon Jan 7 06:50:28 2019 From: noreply at github.com (GitHub) Date: Sun, 06 Jan 2019 21:50:28 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] ff21a4: krb5: change "version" to "instance" in plugin err... Message-ID: <5c32e8a439c4a_63322adf3450058010149e@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: ff21a49cb092292c0b9a3740c1d3ea5804cd0216 https://github.com/heimdal/heimdal/commit/ff21a49cb092292c0b9a3740c1d3ea5804cd0216 Author: Luke Howard Date: 2019-01-07 (Mon, 07 Jan 2019) Changed paths: M lib/krb5/plugin.c Log Message: ----------- krb5: change "version" to "instance" in plugin error message A mismatch of instance cookie just means that the instances of Heimdal do not match; they may in fact be the same version. **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Mon Jan 7 08:09:02 2019 From: noreply at github.com (GitHub) Date: Sun, 06 Jan 2019 23:09:02 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 5abb68: hdb: ensure Salt is zero'd in add_default_salts() Message-ID: <5c32fb0eb40dd_75e32af94fc4057c844eb@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 5abb68c891f14900b881238ce8ff251e479b5d4f https://github.com/heimdal/heimdal/commit/5abb68c891f14900b881238ce8ff251e479b5d4f Author: Luke Howard Date: 2019-01-07 (Mon, 07 Jan 2019) Changed paths: M lib/hdb/common.c Log Message: ----------- hdb: ensure Salt is zero'd in add_default_salts() Ensure Salt is zero'd in add_default_salts(), as the structure has members other than the salt type and value. **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Mon Jan 7 18:55:56 2019 From: noreply at github.com (GitHub) Date: Mon, 07 Jan 2019 09:55:56 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 7808e8: Appveyor: fix SetEnv.cmd invocation Message-ID: <5c3392ac6b1e8_29a82acc1b4e25841569b0@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 7808e898e572a945eba3ae60b08b566726ebc2ad https://github.com/heimdal/heimdal/commit/7808e898e572a945eba3ae60b08b566726ebc2ad Author: Nicolas Williams Date: 2019-01-07 (Mon, 07 Jan 2019) Changed paths: M appveyor.yml Log Message: ----------- Appveyor: fix SetEnv.cmd invocation **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Tue Jan 15 20:21:27 2019 From: noreply at github.com (GitHub) Date: Tue, 15 Jan 2019 11:21:27 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] a3a8c1: ASN.1: Support wider bit sets (fix #514) Message-ID: <5c3e32b731257_65b22ac104b9257c1934f@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: a3a8c1e4a451bb945b436a2dbaa68d783adfaaff https://github.com/heimdal/heimdal/commit/a3a8c1e4a451bb945b436a2dbaa68d783adfaaff Author: Nicolas Williams Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M lib/asn1/gen.c M lib/asn1/gen_decode.c M lib/asn1/gen_glue.c M lib/asn1/test.asn1 M lib/roken/parse_units.h Log Message: ----------- ASN.1: Support wider bit sets (fix #514) Commit: 18226819cdbb99a002b6a618e2f70989900e0b82 https://github.com/heimdal/heimdal/commit/18226819cdbb99a002b6a618e2f70989900e0b82 Author: Nicolas Williams Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M lib/asn1/asn1_gen.c M lib/asn1/gen.c Log Message: ----------- ASN.1 compiler: check write errors Compare: https://github.com/heimdal/heimdal/compare/10164490b7fe...18226819cdbb **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Tue Jan 22 04:30:56 2019 From: noreply at github.com (GitHub) Date: Mon, 21 Jan 2019 19:30:56 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] 3bbd86: WIN32: fix roken build Message-ID: <5c468e70333dd_6d132b03933f057c192f8@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: 3bbd8663b068d0afb5d920517cddd6938f0dc548 https://github.com/heimdal/heimdal/commit/3bbd8663b068d0afb5d920517cddd6938f0dc548 Author: Jeffrey Altman Date: 2019-01-21 (Mon, 21 Jan 2019) Changed paths: M lib/roken/err.c M lib/roken/err.hin M lib/roken/roken.h.in M lib/roken/verr.c M lib/roken/warn.c Log Message: ----------- WIN32: fix roken build __declspec not _declspec Include "err.h" not Include "roken.h" before "err.h" Indent "#if" as "# if" within roken.h.in when CPP rules must be copied into the generated "roken.h". Correct verr() attribute to be ROKEN_LIB_NORETURN_FUNCTION. Change-Id: I4289ecaba4a097175b4a5a1cde529b59038c72e3 Commit: b10ad7eb5795f116e6ad623d0a73d57491d0f271 https://github.com/heimdal/heimdal/commit/b10ad7eb5795f116e6ad623d0a73d57491d0f271 Author: Jeffrey Altman Date: 2019-01-21 (Mon, 21 Jan 2019) Changed paths: M lib/roken/strtoll.c Log Message: ----------- roken: strtoll.c negation is a no-op on unsigned integer strtoll() returns a signed long long not an unsigned long long. When applying the negation for negatives the value must be cast from unsigned to signed and then stored in a signed variable before returning it. Change-Id: If568afd2509d27c7bf206ca59d32ca150cb34857 Commit: 9ce2683f2d98b0f3976e7762382425b21a55ebd2 https://github.com/heimdal/heimdal/commit/9ce2683f2d98b0f3976e7762382425b21a55ebd2 Author: Jeffrey Altman Date: 2019-01-21 (Mon, 21 Jan 2019) Changed paths: M lib/roken/strtoull.c Log Message: ----------- roken: strtoull.c negation is a no-op on unsigned integer strtoull() returns an unsigned long long. However, then the input string represents a negative number the return value is supposed to be the unsigned representation of the negative value. Before applying the negation the value must be cast to (long long). Change-Id: Icf9e75400ff736819b1f7e0e6fb3c8abd707a23a Compare: https://github.com/heimdal/heimdal/compare/18226819cdbb...9ce2683f2d98 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From noreply at github.com Tue Jan 22 06:04:26 2019 From: noreply at github.com (GitHub) Date: Mon, 21 Jan 2019 21:04:26 -0800 Subject: [Heimdal-source-changes] [heimdal/heimdal] f0d928: roken: fix strtoll Message-ID: <5c46a45adb55b_24e32b21c0f4857876421@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/heimdal/heimdal Commit: f0d9289d86e3f4081d096493853c182ca0efef38 https://github.com/heimdal/heimdal/commit/f0d9289d86e3f4081d096493853c182ca0efef38 Author: Jeffrey Altman Date: 2019-01-22 (Tue, 22 Jan 2019) Changed paths: M lib/roken/strtoll.c Log Message: ----------- roken: fix strtoll b10ad7eb5795f116e6ad623d0a73d57491d0f271 ("roken: strtoll.c negation is a no-op on unsigned integer") broke strtoll() by failing to assign 'ret' in the success case. Change-Id: I30535d83a2bef305140f1a6bd1ed2eeba23db9b9 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.