[Heimdal-source-changes] [heimdal/heimdal] 3bbd86: WIN32: fix roken build

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: 3bbd8663b068d0afb5d920517cddd6938f0dc548
      https://github.com/heimdal/heimdal/commit/3bbd8663b068d0afb5d920517cddd6938f0dc548
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2019-01-21 (Mon, 21 Jan 2019)

  Changed paths:
    M lib/roken/err.c
    M lib/roken/err.hin
    M lib/roken/roken.h.in
    M lib/roken/verr.c
    M lib/roken/warn.c

  Log Message:
  -----------
  WIN32: fix roken build

__declspec not _declspec

Include "err.h" not <err.h>

Include "roken.h" before "err.h"

Indent "#if" as "# if" within roken.h.in when CPP rules must be copied
into the generated "roken.h".

Correct verr() attribute to be ROKEN_LIB_NORETURN_FUNCTION.

Change-Id: I4289ecaba4a097175b4a5a1cde529b59038c72e3


  Commit: b10ad7eb5795f116e6ad623d0a73d57491d0f271
      https://github.com/heimdal/heimdal/commit/b10ad7eb5795f116e6ad623d0a73d57491d0f271
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2019-01-21 (Mon, 21 Jan 2019)

  Changed paths:
    M lib/roken/strtoll.c

  Log Message:
  -----------
  roken: strtoll.c negation is a no-op on unsigned integer

strtoll() returns a signed long long not an unsigned long long.
When applying the negation for negatives the value must be cast
from unsigned to signed and then stored in a signed variable
before returning it.

Change-Id: If568afd2509d27c7bf206ca59d32ca150cb34857


  Commit: 9ce2683f2d98b0f3976e7762382425b21a55ebd2
      https://github.com/heimdal/heimdal/commit/9ce2683f2d98b0f3976e7762382425b21a55ebd2
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2019-01-21 (Mon, 21 Jan 2019)

  Changed paths:
    M lib/roken/strtoull.c

  Log Message:
  -----------
  roken: strtoull.c negation is a no-op on unsigned integer

strtoull() returns an unsigned long long.  However, then the input
string represents a negative number the return value is supposed to
be the unsigned representation of the negative value.  Before applying
the negation the value must be cast to (long long).

Change-Id: Icf9e75400ff736819b1f7e0e6fb3c8abd707a23a


Compare: https://github.com/heimdal/heimdal/compare/18226819cdbb...9ce2683f2d98
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.