[Heimdal-source-changes] [heimdal/heimdal] e89e3b: Do not recover log in kadm5_get_principal()

[Viktor Dukhovni]

  Branch: refs/heads/heimdal-7-1-branch
  Home:   https://github.com/heimdal/heimdal
  Commit: e89e3be1346ad4dcd6f8edbd70d5061865ee11b5
      https://github.com/heimdal/heimdal/commit/e89e3be1346ad4dcd6f8edbd70d5061865ee11b5
  Author: Nicolas Williams <nico at twosigma.com>
  Date:   2019-11-08 (Fri, 08 Nov 2019)

  Changed paths:
    M lib/kadm5/get_s.c
    M tests/kdc/check-iprop.in

  Log Message:
  -----------
  Do not recover log in kadm5_get_principal()


  Commit: 5733372241456e8cf4d9052802712dc762e8b262
      https://github.com/heimdal/heimdal/commit/5733372241456e8cf4d9052802712dc762e8b262
  Author: Nicolas Williams <nico at twosigma.com>
  Date:   2019-11-08 (Fri, 08 Nov 2019)

  Changed paths:
    M lib/kadm5/ipropd_slave.c

  Log Message:
  -----------
  ipropd-slave: don't send I_HAVE in response to AYT

ipropd-master sends AYT messages often as a result of a possibly-
transient error, but if the slave responds to such an AYT with I_HAVE,
then the same code path that failed will be executed on the master, and
if the error wasn't transient then we'll loop hard.  So don't send an
I_HAVE in response to an AYT.


  Commit: 360351529c275f307c1dc41aca40bc2e76a2fa55
      https://github.com/heimdal/heimdal/commit/360351529c275f307c1dc41aca40bc2e76a2fa55
  Author: Nicolas Williams <nico at twosigma.com>
  Date:   2019-11-08 (Fri, 08 Nov 2019)

  Changed paths:
    M lib/kadm5/ipropd_master.c

  Log Message:
  -----------
  ipropd-master: use async I/O

If a slave is slow to consume what the master sends it, the master can
block and all iprop operations with it.

With minimal effort we make the master async oriented.


  Commit: 4757a1235326840ddfe054154e1e58c10ec97de0
      https://github.com/heimdal/heimdal/commit/4757a1235326840ddfe054154e1e58c10ec97de0
  Author: Viktor Dukhovni <viktor at twosigma.com>
  Date:   2019-11-08 (Fri, 08 Nov 2019)

  Changed paths:
    M configure.ac
    M include/config.h.w32
    M lib/kadm5/ipropd_master.c
    M lib/kadm5/ipropd_slave.c
    M lib/kadm5/kadm5_locl.h

  Log Message:
  -----------
  Disable Nagle in iprop master and slave


  Commit: 937dfde2e21c0b5db7945dc718a1b0d91fe12274
      https://github.com/heimdal/heimdal/commit/937dfde2e21c0b5db7945dc718a1b0d91fe12274
  Author: Viktor Dukhovni <viktor at twosigma.com>
  Date:   2019-11-08 (Fri, 08 Nov 2019)

  Changed paths:
    M lib/roken/net_write.c

  Log Message:
  -----------
  Handle partial writes on non-blocking sockets

Now that we're using krb5_net_write() with non-blocking sockets in
ipropd_master, we MUST correctly account for partial writes.

Therefore, roken net_write() called from krb5_net_write() now
returns the number of bytes written when the socket error was
EWOULDBLOCK (or EAGAIN).

Also, fix potential issue on Windows, where errno was used instead
of rk_SOCKET_ERRNO whether or not we used _write() or send().


  Commit: bb2fe326066de3dd093768347a54ae3f6ee3a4e9
      https://github.com/heimdal/heimdal/commit/bb2fe326066de3dd093768347a54ae3f6ee3a4e9
  Author: Viktor Dukhovni <viktor at twosigma.com>
  Date:   2019-11-08 (Fri, 08 Nov 2019)

  Changed paths:
    M lib/kadm5/Makefile.am
    M lib/kadm5/ipropd_master.c
    M lib/kadm5/libkadm5srv-exports.def
    M lib/kadm5/log.c
    M lib/kadm5/version-script.map

  Log Message:
  -----------
  Refactor send_diffs making it progressive

When a slave is many diffs behind, send these in batches of up to
50, then handle other slaves.

This also implements a fast-path that makes incremental diffs faster
when the log has not rolled over.

Related code cleanup.


  Commit: f000d703224376d658f99b0765c2d8e3b757b98f
      https://github.com/heimdal/heimdal/commit/f000d703224376d658f99b0765c2d8e3b757b98f
  Author: Viktor Dukhovni <viktor at twosigma.com>
  Date:   2019-11-08 (Fri, 08 Nov 2019)

  Changed paths:
    M lib/kadm5/Makefile.am
    M lib/kadm5/ipropd_master.c
    M lib/kadm5/kadm5_locl.h
    M lib/kadm5/test_pw_quality.c

  Log Message:
  -----------
  Align inclusion of krb5_locl.h with master


Compare: https://github.com/heimdal/heimdal/compare/cd10e32900a0...f000d7032243