[Heimdal-source-changes] [heimdal/heimdal] 7680c9: Don't stutter in send_diffs
Nico Williams
noreply at github.com
Sön Sep 15 06:40:47 CEST 2019
Branch: refs/heads/master
Home: https://github.com/heimdal/heimdal
Commit: 7680c9204791d78b8d56a4bdcee31207380b3d90
https://github.com/heimdal/heimdal/commit/7680c9204791d78b8d56a4bdcee31207380b3d90
Author: Viktor Dukhovni <viktor at twosigma.com>
Date: 2019-09-14 (Sat, 14 Sep 2019)
Changed paths:
M lib/kadm5/ipropd_master.c
Log Message:
-----------
Don't stutter in send_diffs
When the master sees a burst of updates (perhaps sustained), the
slaves "I_HAVE" messages can fall behind the version we've already
sent, and the unpatched code would retransmit already sent diffs!
This can result in substantial amplification (in a local test, 3000
ops turned into 427,000 ops). Though the number of *messages* sent
was actually somewhat smaller, the ever growing message size
ultimately leads to failure.
More information about the Heimdal-source-changes
mailing list