[Heimdal-source-changes] [heimdal/heimdal] 9eab34: gss: don't leak client_cred in test_context

[Luke Howard]

  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: 9eab344d35786444cde0eab100e976e195cc5f89
      https://github.com/heimdal/heimdal/commit/9eab344d35786444cde0eab100e976e195cc5f89
  Author: Luke Howard <lukeh at padl.com>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    M lib/gssapi/test_context.c

  Log Message:
  -----------
  gss: don't leak client_cred in test_context

Don't leak client credential handle in test_context.


  Commit: c70540480bc357f844f4785a784ba3aac0d6f922
      https://github.com/heimdal/heimdal/commit/c70540480bc357f844f4785a784ba3aac0d6f922
  Author: Luke Howard <lukeh at padl.com>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    M lib/gssapi/krb5/acquire_cred.c

  Log Message:
  -----------
  gss: free user keytab before resolving system keytab

get_client_keytab() leaked the user keytab if it resolved but we could not find
the client principal. Free it before trying the system keytab.


  Commit: 9383a88a86a361fcd9c4e9d40cc179e99d5c8b92
      https://github.com/heimdal/heimdal/commit/9383a88a86a361fcd9c4e9d40cc179e99d5c8b92
  Author: Luke Howard <lukeh at padl.com>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    M lib/gssapi/mech/gssspi_exchange_meta_data.c
    M lib/gssapi/mech/gssspi_query_meta_data.c

  Log Message:
  -----------
  gss: honor allocated_ctx in gss_{exchange,query}_meta_data

The NegoEx gss_{exchange,query}_meta_data functions set allocated_ctx but never
did anything with it. Use it to determine whether we should free the context
handle on error.


Compare: https://github.com/heimdal/heimdal/compare/33137a8c8246...9383a88a86a3