[Heimdal-source-changes] [heimdal/heimdal] 037b70: appveyor: Install zstd before other pkgs

[Jeffrey Altman]

  Branch: refs/heads/heimdal-7-1-branch
  Home:   https://github.com/heimdal/heimdal
  Commit: 037b70ea0f297e232bc150341b9dcf0347c38096
      https://github.com/heimdal/heimdal/commit/037b70ea0f297e232bc150341b9dcf0347c38096
  Author: Nicolas Williams <nico at twosigma.com>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M appveyor.yml

  Log Message:
  -----------
  appveyor: Install zstd before other pkgs

Some pacman packages are now being compressed with the ZST algorithm,
but pacman can't handle that unless we first install `zstd`.  This
commit does that.

(cherry picked from commit e3dbc89f8fb6dd0a3a07caee7f752dc2bec3b6d9)


  Commit: 0d51410dba42bacbba25ab11fed0b8aa43dcb589
      https://github.com/heimdal/heimdal/commit/0d51410dba42bacbba25ab11fed0b8aa43dcb589
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M lib/krb5/config_file.c

  Log Message:
  -----------
  krb5: krb5_config_parse_debug initialize output parameters

The caller of krb5_config_parse_debug() expects the output
parameters to be initialized even when the return code is non-zero.
This change initializes the output parameters in case the caller
did not.  Not all code paths assign values to the output parameters
which can result in unexpected termination of the process when
an uninitialized stack pointer is assumed to be valid.

Change-Id: I91859bb5a79ec08b8168e503e267070e2d9315a0


  Commit: 2477c283979d347ed9005a821705cbd788ea9991
      https://github.com/heimdal/heimdal/commit/2477c283979d347ed9005a821705cbd788ea9991
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M lib/krb5/get_cred.c

  Log Message:
  -----------
  lib/krb5: not_found() do not substitute the error text

not_found() is called internally with error code KRB5_CC_NOTFOUND
from find_cred() and get_cred_kdc_capath_worker() where a hard
coded error string "Matching credential not found" makes sense.
However, it is also called from krb5_get_creds() and
krb5_get_credentials_with_flags() with error codes that are
returned from the KDC where hiding the true error string
confuses the end user and hampers debugging.

This change replaces the hard coded string with the result
of krb5_get_error_message() and appends the service ticket
name.

Change-Id: I275c66c7b5783ae25029dce5b851cb389b118bcc
(cherry picked from commit fde95037a8558aeaf47797f39fc9a1645819a040)


Compare: https://github.com/heimdal/heimdal/compare/a028bfbf830c...2477c283979d