[Heimdal-source-changes] [heimdal/heimdal] 5e690f: Avoid -Werror=address failure due to embedded NULL...

[Andrew Bartlett]

  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: 5e690fe70cd763dbc66ad3e313994c9a0271ca95
      https://github.com/heimdal/heimdal/commit/5e690fe70cd763dbc66ad3e313994c9a0271ca95
  Author: Andrew Bartlett <abartlet at samba.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M lib/gssapi/mech/gss_krb5.c

  Log Message:
  -----------
  Avoid -Werror=address failure due to embedded NULL check in _mg_buffer_zero

Seen with Ubuntu 18.04
gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04)

mech/gss_krb5.c: In function ‘gss_krb5_ccache_name’:
mech/gss_krb5.c:501:18: error: the address of ‘buffer’ will always evaluate as ‘true’ [-Werror=address]
  _mg_buffer_zero(&buffer);
                  ^
mech/mech_locl.h:72:7: note: in definition of macro ‘_mg_buffer_zero’
   if (buffer) {   \
       ^~~~~~

Signed-off-by: Andrew Bartlett <abartlet at samba.org>


  Commit: 9142a46e89b1e2a312e1e2ed4ea8f9a934f318d4
      https://github.com/heimdal/heimdal/commit/9142a46e89b1e2a312e1e2ed4ea8f9a934f318d4
  Author: Andrew Bartlett <abartlet at samba.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  Do a strict ./configure --enable-developer build to make warnings errors in CI

This will make it harder to commit code that triggers warnings.

This list of allowed warnings is too long, but can be trimmed down
over time.

Signed-off-by: Andrew Bartlett <abartlet at samba.org>


Compare: https://github.com/heimdal/heimdal/compare/d84512b8d2b7...9142a46e89b1