[Heimdal-source-changes] [heimdal/heimdal] 6f0caf: heimdal: handle referrals for 3 part DRSUAPI SPNs

GitHub noreply at github.com
Tis Mars 25 05:08:19 CET 2014


  Branch: refs/heads/master
  Home:   https://github.com/heimdal/heimdal
  Commit: 6f0cafa6cf5957ee549e46e899e8bc83eeca52c2
      https://github.com/heimdal/heimdal/commit/6f0cafa6cf5957ee549e46e899e8bc83eeca52c2
  Author: Andrew Tridgell <tridge at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M kdc/krb5tgs.c

  Log Message:
  -----------
  heimdal: handle referrals for 3 part DRSUAPI SPNs

This handles referrals for SPNs of the form
E3514235-4B06-11D1-AB04-00C04FC2DCD2/NTDSGUID/REALM, which are
used during DRS replication when we don't know the dnsHostName of the
target DC (which we don't know until the first replication from that
DC completes).

We use the 3rd part of the SPN directly as the realm name in the
referral.

Pair-Programmed-With: Andrew Bartlett <abartlet at samba.org>


  Commit: cfc398d32eec3ee68f7f8ec2729924393e3f5bed
      https://github.com/heimdal/heimdal/commit/cfc398d32eec3ee68f7f8ec2729924393e3f5bed
  Author: Andreas Schneider <asn at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    A gssapi/krb5/cfx.c b/lib/gssapi/krb5/cfx.c
    R gssapi/krb5/cfx.c b/lib/gssapi/krb5/cfx.c

  Log Message:
  -----------
  s4-heimdal: Remove the execute flag of cfx.c.

The scripts which are extracting debuginfo are looking for files with
the executable bit and find cfx.c which isn't a executable.


  Commit: c281ad6ccbb2b5185089ef6a30da7a60c6e94577
      https://github.com/heimdal/heimdal/commit/c281ad6ccbb2b5185089ef6a30da7a60c6e94577
  Author: Volker Lendecke <vl at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/krb5/misc.c

  Log Message:
  -----------
  heimdal: Fix the build on FreeBSD

We don't have BACKTRACE_SYMBOLS by default


  Commit: 506780a160def11062da7bf5b89d68913a8652f4
      https://github.com/heimdal/heimdal/commit/506780a160def11062da7bf5b89d68913a8652f4
  Author: Stefan Metzmacher <metze at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/krb5/expand_path.c

  Log Message:
  -----------
  heimdal:lib/krb5: don't name a struct 'token'

This is a static const struct and the name is never used,
so just make it an anonymous struct.

This hopefully fixes the build on AIX:

"../lib/roken/roken-common.h", line 276.9: 1506-236 (W) Macro name __attribute__ has been redefined.
"../lib/roken/roken-common.h", line 276.9: 1506-358 (I) "__attribute__" is defined on line 45 of ../lib/com_err/com_err.h.
"../lib/krb5/expand_path.c", line 331.21: 1506-334 (S) Identifier token has already been defined on line 98 of "/usr/include/net/if_arp.h".
"../lib/krb5/expand_path.c", line 390.43: 1506-019 (S) Expecting an array or a pointer to object type.
"../lib/krb5/expand_path.c", line 391.31: 1506-019 (S) Expecting an array or a pointer to object type.
"../lib/krb5/expand_path.c", line 392.20: 1506-019 (S) Expecting an array or a pointer to object type.
"../lib/krb5/expand_path.c", line 392.48: 1506-019 (S) Expecting an array or a pointer to object type.
"../lib/krb5/expand_path.c", line 393.39: 1506-019 (S) Expecting an array or a pointer to object type.
Waf: Leaving directory `/opt/home/build/build_farm/samba_4_0_test/bin'
Build failed:  -> task failed (err #1):
	{task: cc expand_path.c -> expand_path_52.o}
gmake: *** [all] Error 1

metze

Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sat Jun 16 15:20:59 CEST 2012 on sn-devel-104


  Commit: 2596cfe3245cce523cc27292a9f8d39bb98a8b63
      https://github.com/heimdal/heimdal/commit/2596cfe3245cce523cc27292a9f8d39bb98a8b63
  Author: Stefan Metzmacher <metze at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/wind/gen-errorlist.py

  Log Message:
  -----------
  heimdal:lib/wind: make sure errorlist_table.c includes config.h as first header

This should fix the build on AIX.

metze

Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sat Jun 16 23:59:07 CEST 2012 on sn-devel-104


  Commit: 1ae5df045e6bb9497ec53fb36b0f5db5f941c10e
      https://github.com/heimdal/heimdal/commit/1ae5df045e6bb9497ec53fb36b0f5db5f941c10e
  Author: Stefan Metzmacher <metze at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/wind/gen-bidi.py
    M lib/wind/gen-combining.py
    M lib/wind/gen-normalize.py

  Log Message:
  -----------
  heimdal:lib/wind: include <stdlib.h> at the end

This makes sure config.h gets includes first.

This should fix the build on AIX.

metze

Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sun Jun 17 16:16:24 CEST 2012 on sn-devel-104


  Commit: b408e93ae3cbd29c84ba45ea1d25f8b02fc6a82d
      https://github.com/heimdal/heimdal/commit/b408e93ae3cbd29c84ba45ea1d25f8b02fc6a82d
  Author: Volker Lendecke <vl at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/gssapi/krb5/init_sec_context.c

  Log Message:
  -----------
  heimdal: Fix 241482 Resource leak

Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>


  Commit: 2aca5c4faef2914a1227bb8a635281793ef8bc6e
      https://github.com/heimdal/heimdal/commit/2aca5c4faef2914a1227bb8a635281793ef8bc6e
  Author: Volker Lendecke <vl at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/krb5/get_addrs.c

  Log Message:
  -----------
  heimdal: Fix CID 241943 Uninitialized pointer read

In the error case without EXTRA_ADDRESSES we access ignore_addresses
without initialization

Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>


  Commit: 56bcd356d880e8959474a969ffa438f44d8a7b19
      https://github.com/heimdal/heimdal/commit/56bcd356d880e8959474a969ffa438f44d8a7b19
  Author: Volker Lendecke <vl at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/krb5/context.c

  Log Message:
  -----------
  heimdal: Fix CID 240779 Allocation size mismatch

(rebased on current Heimdal by abartlet)

The error Coverity complains about is in the malloc. krb5_enctypes is
an enum, so it is usually smaller than the size of a pointer. So we
overallocate, but in the memcpy further down we copy from potentially
invalid memory.

Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>

Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Wed Nov 13 11:05:44 CET 2013 on sn-devel-104


  Commit: ba26fa550208e194982bf21725aeb8283410c7a4
      https://github.com/heimdal/heimdal/commit/ba26fa550208e194982bf21725aeb8283410c7a4
  Author: Volker Lendecke <vl at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/roken/rkpty.c

  Log Message:
  -----------
  heimdal: Fix a format error on FreeBSD10

Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>


  Commit: ccc4302a183bfb110a47ff7fd3f4c3ba1e6752ce
      https://github.com/heimdal/heimdal/commit/ccc4302a183bfb110a47ff7fd3f4c3ba1e6752ce
  Author: Andrew Bartlett <abartlet at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/asn1/gen_locl.h

  Log Message:
  -----------
  lib/asn1: Add extern to declaration of fuzzer string in gen_locl.h


  Commit: 2622b32468118fda4cee7567e1efc17e962b29ea
      https://github.com/heimdal/heimdal/commit/2622b32468118fda4cee7567e1efc17e962b29ea
  Author: Andrew Bartlett <abartlet at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/base/baselocl.h

  Log Message:
  -----------
  lib/base: Add define for HEIMDAL_TEXTDOMAIN


  Commit: 9f392c134fae066660cf56bcbcd8e1012677960a
      https://github.com/heimdal/heimdal/commit/9f392c134fae066660cf56bcbcd8e1012677960a
  Author: Andrew Bartlett <abartlet at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/krb5/send_to_kdc.c

  Log Message:
  -----------
  heimdal: rename send and recv pointers to avoid conflict with socket wrapper


  Commit: 1fad1f8984baa0de258b09c06f0870e298be6c85
      https://github.com/heimdal/heimdal/commit/1fad1f8984baa0de258b09c06f0870e298be6c85
  Author: Andrew Bartlett <abartlet at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/base/json.c

  Log Message:
  -----------
  lib/base: Rename strbuf to heim_strbuf to avoid conflict with stropts.h on linux


Compare: https://github.com/heimdal/heimdal/compare/cc495fd78d13...1fad1f8984ba


More information about the Heimdal-source-changes mailing list