[Heimdal-source-changes] [heimdal/heimdal] b5f926: heimdal: handle referrals for 3 part DRSUAPI SPNs

GitHub noreply at github.com
Tis Mars 25 05:21:19 CET 2014


  Branch: refs/heads/heimdal-1-6-branch
  Home:   https://github.com/heimdal/heimdal
  Commit: b5f926bb6946ded55f68eaa1a45432d1fe4a5c2d
      https://github.com/heimdal/heimdal/commit/b5f926bb6946ded55f68eaa1a45432d1fe4a5c2d
  Author: Andrew Tridgell <tridge at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M kdc/krb5tgs.c

  Log Message:
  -----------
  heimdal: handle referrals for 3 part DRSUAPI SPNs

This handles referrals for SPNs of the form
E3514235-4B06-11D1-AB04-00C04FC2DCD2/NTDSGUID/REALM, which are
used during DRS replication when we don't know the dnsHostName of the
target DC (which we don't know until the first replication from that
DC completes).

We use the 3rd part of the SPN directly as the realm name in the
referral.

Pair-Programmed-With: Andrew Bartlett <abartlet at samba.org>


  Commit: 889a4d6af2567116ca60f1ac2af428ac045c7d7a
      https://github.com/heimdal/heimdal/commit/889a4d6af2567116ca60f1ac2af428ac045c7d7a
  Author: Andreas Schneider <asn at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    A gssapi/krb5/cfx.c b/lib/gssapi/krb5/cfx.c
    R gssapi/krb5/cfx.c b/lib/gssapi/krb5/cfx.c

  Log Message:
  -----------
  s4-heimdal: Remove the execute flag of cfx.c.

The scripts which are extracting debuginfo are looking for files with
the executable bit and find cfx.c which isn't a executable.


  Commit: 2e77a006af8f56907a93304ca77e7cdd5be9f22f
      https://github.com/heimdal/heimdal/commit/2e77a006af8f56907a93304ca77e7cdd5be9f22f
  Author: Volker Lendecke <vl at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/krb5/misc.c

  Log Message:
  -----------
  heimdal: Fix the build on FreeBSD

We don't have BACKTRACE_SYMBOLS by default


  Commit: 4f32743064447761078adf37ae1ff5fc3bafe17e
      https://github.com/heimdal/heimdal/commit/4f32743064447761078adf37ae1ff5fc3bafe17e
  Author: Stefan Metzmacher <metze at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/krb5/expand_path.c

  Log Message:
  -----------
  heimdal:lib/krb5: don't name a struct 'token'

This is a static const struct and the name is never used,
so just make it an anonymous struct.

This hopefully fixes the build on AIX:

"../lib/roken/roken-common.h", line 276.9: 1506-236 (W) Macro name __attribute__ has been redefined.
"../lib/roken/roken-common.h", line 276.9: 1506-358 (I) "__attribute__" is defined on line 45 of ../lib/com_err/com_err.h.
"../lib/krb5/expand_path.c", line 331.21: 1506-334 (S) Identifier token has already been defined on line 98 of "/usr/include/net/if_arp.h".
"../lib/krb5/expand_path.c", line 390.43: 1506-019 (S) Expecting an array or a pointer to object type.
"../lib/krb5/expand_path.c", line 391.31: 1506-019 (S) Expecting an array or a pointer to object type.
"../lib/krb5/expand_path.c", line 392.20: 1506-019 (S) Expecting an array or a pointer to object type.
"../lib/krb5/expand_path.c", line 392.48: 1506-019 (S) Expecting an array or a pointer to object type.
"../lib/krb5/expand_path.c", line 393.39: 1506-019 (S) Expecting an array or a pointer to object type.
Waf: Leaving directory `/opt/home/build/build_farm/samba_4_0_test/bin'
Build failed:  -> task failed (err #1):
	{task: cc expand_path.c -> expand_path_52.o}
gmake: *** [all] Error 1

metze

Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sat Jun 16 15:20:59 CEST 2012 on sn-devel-104


  Commit: f7410d4a05373af7596ffd05658ee051bf5dce3a
      https://github.com/heimdal/heimdal/commit/f7410d4a05373af7596ffd05658ee051bf5dce3a
  Author: Stefan Metzmacher <metze at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/wind/gen-errorlist.py

  Log Message:
  -----------
  heimdal:lib/wind: make sure errorlist_table.c includes config.h as first header

This should fix the build on AIX.

metze

Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sat Jun 16 23:59:07 CEST 2012 on sn-devel-104


  Commit: d85ec4272c1604bab173f812a4a163cc920ad6ed
      https://github.com/heimdal/heimdal/commit/d85ec4272c1604bab173f812a4a163cc920ad6ed
  Author: Stefan Metzmacher <metze at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/wind/gen-bidi.py
    M lib/wind/gen-combining.py
    M lib/wind/gen-normalize.py

  Log Message:
  -----------
  heimdal:lib/wind: include <stdlib.h> at the end

This makes sure config.h gets includes first.

This should fix the build on AIX.

metze

Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sun Jun 17 16:16:24 CEST 2012 on sn-devel-104


  Commit: d4d47b61f93f9d140833eeb838867df26959a0a0
      https://github.com/heimdal/heimdal/commit/d4d47b61f93f9d140833eeb838867df26959a0a0
  Author: Volker Lendecke <vl at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/gssapi/krb5/init_sec_context.c

  Log Message:
  -----------
  heimdal: Fix 241482 Resource leak

Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>


  Commit: 0a6a78599be3c6be8dded227d95a04d6dd28d351
      https://github.com/heimdal/heimdal/commit/0a6a78599be3c6be8dded227d95a04d6dd28d351
  Author: Volker Lendecke <vl at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/krb5/get_addrs.c

  Log Message:
  -----------
  heimdal: Fix CID 241943 Uninitialized pointer read

In the error case without EXTRA_ADDRESSES we access ignore_addresses
without initialization

Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>


  Commit: 92f43148f6a34aa2fc2b6c19da1e210ed2ed6c4f
      https://github.com/heimdal/heimdal/commit/92f43148f6a34aa2fc2b6c19da1e210ed2ed6c4f
  Author: Volker Lendecke <vl at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/krb5/context.c

  Log Message:
  -----------
  heimdal: Fix CID 240779 Allocation size mismatch

(rebased on current Heimdal by abartlet)

The error Coverity complains about is in the malloc. krb5_enctypes is
an enum, so it is usually smaller than the size of a pointer. So we
overallocate, but in the memcpy further down we copy from potentially
invalid memory.

Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>

Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Wed Nov 13 11:05:44 CET 2013 on sn-devel-104


  Commit: caac9afec843c1a4c6100b52a5f6eb917f0cb1ae
      https://github.com/heimdal/heimdal/commit/caac9afec843c1a4c6100b52a5f6eb917f0cb1ae
  Author: Volker Lendecke <vl at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/roken/rkpty.c

  Log Message:
  -----------
  heimdal: Fix a format error on FreeBSD10

Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>


  Commit: ff1574a903265f6f7563d657965f635c7e4fe77f
      https://github.com/heimdal/heimdal/commit/ff1574a903265f6f7563d657965f635c7e4fe77f
  Author: Andrew Bartlett <abartlet at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/asn1/gen_locl.h

  Log Message:
  -----------
  lib/asn1: Add extern to declaration of fuzzer string in gen_locl.h


  Commit: cc3aa7864cc08e378a7ce31da1a0bd224cb0e84f
      https://github.com/heimdal/heimdal/commit/cc3aa7864cc08e378a7ce31da1a0bd224cb0e84f
  Author: Andrew Bartlett <abartlet at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/base/baselocl.h

  Log Message:
  -----------
  lib/base: Add define for HEIMDAL_TEXTDOMAIN


  Commit: 9df368e8f54d665659e91209ebb1195965b6d1da
      https://github.com/heimdal/heimdal/commit/9df368e8f54d665659e91209ebb1195965b6d1da
  Author: Andrew Bartlett <abartlet at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/krb5/send_to_kdc.c

  Log Message:
  -----------
  heimdal: rename send and recv pointers to avoid conflict with socket wrapper


  Commit: ff7b1891a3ff9bda496cff1ae2d471cb2c18242d
      https://github.com/heimdal/heimdal/commit/ff7b1891a3ff9bda496cff1ae2d471cb2c18242d
  Author: Andrew Bartlett <abartlet at samba.org>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M lib/base/json.c

  Log Message:
  -----------
  lib/base: Rename strbuf to heim_strbuf to avoid conflict with stropts.h on linux


Compare: https://github.com/heimdal/heimdal/compare/147c5e17fa08...ff7b1891a3ff


More information about the Heimdal-source-changes mailing list