[Heimdal-source-changes] [heimdal/heimdal] 14af1e: lib/kadm5: improve kadm_c_ error handling

[GitHub]

  Branch: refs/heads/jaltman/kadm_c_error_handling
  Home:   https://github.com/heimdal/heimdal
  Commit: 14af1e9803f6972fe25337d0ecc62da806612a22
      https://github.com/heimdal/heimdal/commit/14af1e9803f6972fe25337d0ecc62da806612a22
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2018-12-24 (Mon, 24 Dec 2018)

  Changed paths:
    M lib/kadm5/chpass_c.c
    M lib/kadm5/create_c.c
    M lib/kadm5/delete_c.c
    M lib/kadm5/get_c.c
    M lib/kadm5/get_princs_c.c
    M lib/kadm5/modify_c.c
    M lib/kadm5/privs_c.c
    M lib/kadm5/randkey_c.c
    M lib/kadm5/rename_c.c

  Log Message:
  -----------
  lib/kadm5: improve kadm_c_ error handling

Perform error checking for each function call and consistently return
errors at the point of failure.

Refactor functions to use a common exit path.  Preserve error messages
stored in the kadm5_client_context.context when appropriate.

Change-Id: I7aa04020e4de3454066f0d88ba805fed999dbd1a


  Commit: 006f43a7e62ab4cd4730b1ce553897df6d436a6c
      https://github.com/heimdal/heimdal/commit/006f43a7e62ab4cd4730b1ce553897df6d436a6c
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2018-12-24 (Mon, 24 Dec 2018)

  Changed paths:
    M lib/kadm5/ad.c
    M lib/kadm5/chpass_c.c
    M lib/kadm5/common_glue.c
    M lib/kadm5/context_s.c
    M lib/kadm5/create_c.c
    M lib/kadm5/delete_c.c
    M lib/kadm5/get_c.c
    M lib/kadm5/get_princs_c.c
    M lib/kadm5/get_princs_s.c
    M lib/kadm5/get_s.c
    M lib/kadm5/init_c.c
    M lib/kadm5/ipropd_master.c
    M lib/kadm5/ipropd_slave.c
    M lib/kadm5/log.c
    M lib/kadm5/modify_c.c
    M lib/kadm5/modify_s.c
    M lib/kadm5/privs_c.c
    M lib/kadm5/randkey_c.c
    M lib/kadm5/rename_c.c
    M lib/kadm5/rename_s.c
    M lib/kadm5/send_recv.c
    M lib/kadm5/set_keys.c
    M lib/kadm5/set_modifier.c

  Log Message:
  -----------
  lib/kadm5: use krb5_enomem() where possible

Change-Id: I487fbc640a8f793f0aa02ef4c94099e09241d616


Compare: https://github.com/heimdal/heimdal/compare/a9c9ff40d6b8...006f43a7e62a
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.