[Heimdal-source-changes] [heimdal/heimdal] 30ce6f: lib/krb5: krcc_remove_cred remove dead code

[GitHub]

  Branch: refs/heads/jaltman/krcache-coverity
  Home:   https://github.com/heimdal/heimdal
  Commit: 30ce6f47bd3466010598e0e35321c8eb93e1d276
      https://github.com/heimdal/heimdal/commit/30ce6f47bd3466010598e0e35321c8eb93e1d276
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2018-12-24 (Mon, 24 Dec 2018)

  Changed paths:
    M lib/krb5/krcache.c

  Log Message:
  -----------
  lib/krb5: krcc_remove_cred remove dead code

At the completion of the while loop the value of 'ret' cannot
be zero.  The expected value is KRB5_CC_END.  Any other value
is an error to return to the caller.  If 'ret' is KRB5_CC_END
then return krcc_end_get() result().

Change-Id: Ic2afb5a754e03d521c10a259c53fc70b86b4a132


  Commit: f84009ab1340b44ef15bdfe62eb05d1892a709cb
      https://github.com/heimdal/heimdal/commit/f84009ab1340b44ef15bdfe62eb05d1892a709cb
  Author: Jeffrey Altman <jaltman at secure-endpoints.com>
  Date:   2018-12-24 (Mon, 24 Dec 2018)

  Changed paths:
    M lib/krb5/krcache.c

  Log Message:
  -----------
  lib/krb5: krcache add_unique_keyring dead code removal

After the for loop 'key' cannot have the value -1.  The loop
must execute at least once resulting either in the function
returning to the caller or the value of 'key' getting set to
a value other than -1.

Change-Id: Idaf65e3cf3d22a27828ad0dd04650a4f54ba94fc


Compare: https://github.com/heimdal/heimdal/compare/30ce6f47bd34^...f84009ab1340
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.